Opened 10 years ago
Closed 10 years ago
#12227 closed Patch - Bug Fix (Fixed)
CC708Reader::Reset should delete all windows
Reported by: | Owned by: | Jim Stichnoth | |
---|---|---|---|
Priority: | minor | Milestone: | 0.27.4 |
Component: | MythTV - Captions | Version: | 0.27-fixes |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Discovered what I think may be a bug just by reading the code. According to wikipedia, a Reset command should delete all windows, but it looks to me like only windows 0, 1 and 2 will be deleted because the value of the window_map argument to DeleteWindows? is 0x7. The attached patch changes it to 0xff. I don't have a test case.
Attachments (1)
Change History (5)
Changed 10 years ago by
Attachment: | 708-reset-all-windows.patch added |
---|
comment:1 Changed 10 years ago by
Milestone: | unknown → 0.27.4 |
---|---|
Status: | new → accepted |
comment:4 Changed 10 years ago by
Resolution: | → Fixed |
---|---|
Status: | accepted → closed |
Note: See
TracTickets for help on using
tickets.
I think that in practice, generally only windows 0 and 1 are used, which is probably why this hasn't been reported before, but yeah, it looks like a bug.