Opened 5 years ago

Closed 5 years ago

#12227 closed Patch - Bug Fix (Fixed)

CC708Reader::Reset should delete all windows

Reported by: faginbagin <mythtv@…> Owned by: Jim Stichnoth
Priority: minor Milestone: 0.27.4
Component: MythTV - Captions Version: 0.27-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Discovered what I think may be a bug just by reading the code. According to wikipedia, a Reset command should delete all windows, but it looks to me like only windows 0, 1 and 2 will be deleted because the value of the window_map argument to DeleteWindows? is 0x7. The attached patch changes it to 0xff. I don't have a test case.

Attachments (1)

708-reset-all-windows.patch (480 bytes) - added by faginbagin <mythtv@…> 5 years ago.

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by faginbagin <mythtv@…>

Attachment: 708-reset-all-windows.patch added

comment:1 Changed 5 years ago by Jim Stichnoth

Milestone: unknown0.27.4
Status: newaccepted

I think that in practice, generally only windows 0 and 1 are used, which is probably why this hasn't been reported before, but yeah, it looks like a bug.

comment:2 Changed 5 years ago by faginbagin <mythtv@…>

In e97f4f59806a32421a2d2ab4c79549286c56b6ab/mythtv:

Captions: Delete *all* cc708 windows in CC708Reader::Reset().

Refs #12227.

Signed-off-by: Jim Stichnoth <jstichnoth@…>

comment:3 Changed 5 years ago by Jim Stichnoth <jstichnoth@…>

In 5e37f9cf53e196459c59faceb9317e4e755df4eb/mythtv:

Captions: Delete *all* cc708 windows in CC708Reader::Reset().

Refs #12227.

Signed-off-by: Jim Stichnoth <jstichnoth@…>
(cherry picked from commit e97f4f59806a32421a2d2ab4c79549286c56b6ab)

Conflicts:

mythtv/libs/libmythtv/cc708reader.cpp

comment:4 Changed 5 years ago by Jim Stichnoth

Resolution: Fixed
Status: acceptedclosed
Note: See TracTickets for help on using tickets.