Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#12232 closed Patch - Bug Fix (fixed)

Patch to address Coverity reported (potential) integer overflow - fixes Coverity 1229296

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: stuartm
Priority: minor Milestone: 0.28
Component: MythTV - EIT Version: Unspecified
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Coverity reported a potential integer overflow. While the values cannot overflow when shifted by 16 bits, Coverity does not understand that. For code cleanliness, fix it by moving the cast, and add other casts in the same code fragment.

Fixes Coverity 1229296

github ref: ​https://github.com/garybuhrmaster/mythtv/commit/d7c8d637091ada04984fc4ca6be2477c24b216a2

github git-am ref: ​https://github.com/garybuhrmaster/mythtv/commit/d7c8d637091ada04984fc4ca6be2477c24b216a2.patch

Change History (3)

comment:1 Changed 10 years ago by stuartm

Owner: changed from Karl Egly to stuartm
Status: new → accepted

comment:2 Changed 10 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: → fixed
Status: accepted → closed

In 3d82556e297d3a4c464b8851616bee6e203588d7/mythtv:

Explicit casts for eit fixup

Signed-off-by: Stuart Morgan <smorgan@…>

Fixes #12232
Coverity 1229296

comment:3 Changed 10 years ago by paulh

Milestone: unknown → 0.28
Note: See TracTickets for help on using tickets.