Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#12246 closed Bug Report - General (fixed)

Artwork pulled is lowest ranked from source

Reported by: skd5aner@… Owned by: JYA
Priority: minor Milestone: 0.27.5
Component: MythTV - Mythmetadatalookup Version: 0.27-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I'm finding that all the artwork that MythTV is automatically pulling from TMDB and TheTVDB is always (or almost always) the lowest ranked image. If there are several images with the same ranking, it selects the first tied, lowest ranking image. This usually results in sub-part background images. I have not checked if this problem applies to coverart and banners, but it may.

For example, from TMDB, the movie "Runner Runner" (https://www.themoviedb.org/movie/146238-runner-runner/backdrops) automatically returns the least ranked image: https://image.tmdb.org/t/p/original/11dpIMkMn8MmbDr69ENgwLngLr0.jpg

And from TheTVDB, the TV show "Last Week Tonight with John Oliver" (http://thetvdb.com/?tab=seriesfanart&id=278518) returns the least ranked image: http://thetvdb.com/banners/fanart/original/278518-3.jpg

I would expect the grabber to automatically grab the highest rated artwork by default.

Running: MythTV Version : v0.27.3-107-gf91e18d MythTV Branch : fixes/0.27

Change History (4)

comment:1 Changed 5 years ago by skd5aner@…

I tracked down this change made by Raymond (#11678, commit: da8ac305c3). Additionally, I remembered Stuart M. made this change: d95a237d.

Stuart's change actually resolved the issue, and when manually selecting artwork, the order was always right. But with the automated artwork retrieval, Raymond's change reversed the order. I tested in 0.27-fixes, and reverted Raymond's commit, and I can confirm that it selected the highest rated fanart in both the automated retrieval as well as in the manual GUI selection list.

Thanks to Stuart M for talking through it with me on IRC while I troubleshooted and tested.

comment:2 Changed 5 years ago by Stuart Morgan <smorgan@…>

Resolution: fixed
Status: newclosed

In 09422c5508a74c0d052a78ee14fb4a20ce9ca058/mythtv:

Revert "Fix metadata fanart selection."

The fix for this issue was addressed at a lower level in another
commit as a result this code path was reversing the list again.

Fixes #12246

This reverts commit da8ac305c3dbe955459a6a12e646b81109552836.

Conflicts:

mythtv/libs/libmythmetadata/metadatafactory.cpp

comment:3 Changed 5 years ago by Stuart Morgan <smorgan@…>

In a2563e13062298467480cd8465153cdc7e851f05/mythtv:

Revert "Fix metadata fanart selection."

The fix for this issue was addressed at a lower level in another
commit as a result this code path was reversing the list again.

Fixes #12246

This reverts commit da8ac305c3dbe955459a6a12e646b81109552836.

Conflicts:

mythtv/libs/libmythmetadata/metadatafactory.cpp

(cherry picked from commit 09422c5508a74c0d052a78ee14fb4a20ce9ca058)

comment:4 Changed 4 years ago by Karl Egly

Milestone: unknown0.27.5
Note: See TracTickets for help on using tickets.