Opened 5 years ago

Last modified 5 years ago

#12276 new Patch - Bug Fix

[PATCH] Fix channel display on mythweb schedules page

Reported by: Karl Newman <SiliconFiend@…> Owned by: Rob Smith
Priority: minor Milestone: unknown
Component: Plugin - MythWeb Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In the course of improving mythweb's handling of the "This Channel" filter with the patch in #11970, I apparently uncovered another older bug where the channel name and number was being clobbered by later schedules which shared the same channel due to a shared channel object. In other words, a schedule with the "This Channel" set would show "[Any]" instead of the specified channel number and name if there was another "Any Channel" schedule loaded after which was based on a program from that same channel, because the template modified the (shared) channel object name to "[Any]".

I'm creating a new ticket instead of re-opening the old ticket. I also expanded the logic to include "Find Daily" and "Find Weekly" schedules because those are also "Find Any" unless the "This Channel" filter is set.

The attached patch is against Master.

Attachments (1)

mythweb_schedules_any_fix.patch (3.2 KB) - added by Karl Newman <SiliconFiend@…> 5 years ago.
Schedules "Any Channel" fix

Download all attachments as: .zip

Change History (2)

Changed 5 years ago by Karl Newman <SiliconFiend@…>

Schedules "Any Channel" fix

comment:1 Changed 5 years ago by setnes@…

This is working well for me now. Thanks.

I wonder if the text for the fourth radio button under "Schedule Options" should read "Record at any time" instead of "Record at any time on any channel." It seems like the "on any channel" part is not at all controlled by that radio button anymore. It is controlled by the "This channel" filter check box instead.

Note: See TracTickets for help on using tickets.