Opened 5 years ago

Closed 5 years ago

#12285 closed Patch - Bug Fix (fixed)

Edit Schedule/Preview broken

Reported by: Roger Siddons <dizygotheca@…> Owned by: stuartm
Priority: minor Milestone: 0.28
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The Preview display of Edit Recording Rule was broken by [d013e5426fac8c654159cfb12467da55106b5e4b].

It currently displays the schedule for all rules except the one being edited, plus changes.

viewschedulediff.cpp generates the display from the difference between the current schedule and a temporary schedule run with any edits applied. This strategy now fails because the temporary schedule is being filtered by recordid in LoadFromScheduler and not returning the full schedule.

Custom Recording Priorities/Test also uses this display, but still works as it uses a recordid of 0 and is not filtered.

Attachments (1)

do_not_filter_preview.patch (1.8 KB) - added by Roger Siddons <dizygotheca@…> 5 years ago.
Don't filter schedules produced for Edit Schedule/Preview?

Download all attachments as: .zip

Change History (3)

Changed 5 years ago by Roger Siddons <dizygotheca@…>

Attachment: do_not_filter_preview.patch added

Don't filter schedules produced for Edit Schedule/Preview?

comment:1 Changed 5 years ago by stuartm

Milestone: unknown0.28
Owner: set to stuartm
Status: newaccepted

comment:2 Changed 5 years ago by Stuart Morgan <smorgan@…>

Resolution: fixed
Status: acceptedclosed

In e3d17b6a7748c042b1d37daa4513eaa11700493b/mythtv:

Revert [ab8667337e17d74d4f6c0649bde83aae5c16c651] and part of [d013e5426fac8c654159cfb12467da55106b5e4b]. Move the filtering by recordid into the services class instead. The archaic scheduler code is a minefield and fragile, safer just to avoid modifying it and in future work on implementing a simpler, cleaner and documented interface. Fixes #12285.

Note: See TracTickets for help on using tickets.