Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#12286 closed Patch - Feature (fixed)

Edit Schedule/Preview doesn't show a preview

Reported by: Roger Siddons <dizygotheca@…> Owned by: gigem
Priority: minor Milestone: 0.28
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The Edit Recording Rule/Preview display only shows *changes* to the schedule that result from applying the edits, which isn't overly useful on its own. Intuitively it's not a "preview" of the rule.

Moreover some themes display "No recordings are scheduled" if there are no changes, which is misleading.

This patch includes the full schedule for the rule, ie. {current Upcoming scheduled for this rule} vs. {Upcoming scheduled for this rule after edit} UNION {changes to any other rule}.

Attachments (1)

enhance_preview.patch (619 bytes) - added by Roger Siddons <dizygotheca@…> 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by Roger Siddons <dizygotheca@…>

Attachment: enhance_preview.patch added

comment:1 Changed 5 years ago by gigem

Owner: set to gigem
Status: newaccepted

The current code is correct. "Preview" is short for "Preview Changes". There is an "Upcoming Recordings" menu option for seeing just the programs matching the rule. I am fixing the theme text when there are no schedule changes, though.

comment:2 Changed 5 years ago by David Engel <dengel@…>

Resolution: fixed
Status: acceptedclosed

In 022e67cb929d6648cd4920dc3fd3b9c48e0cc3cc/mythtv:

Fix the theme text when there are no scheduler changes.

Fixes #12286

comment:3 Changed 5 years ago by paulh

Milestone: unknown0.28
Note: See TracTickets for help on using tickets.