Opened 3 years ago
Last modified 2 years ago
#12365 accepted Patch - Bug Fix
Patch: Update Perl and Python bindings proto version and token
| Reported by: | Owned by: | Raymond Wagner | |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | Bindings - Python | Version: | Master Head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Please see attached patch.
Attachments (1)
Change History (6)
Changed 3 years ago by
| Attachment: | perl-python-token-version-update.patch.v0 added |
|---|
comment:1 Changed 3 years ago by
Unfortunately this isn't enough, the python bindings actually used one of the events that was changed in the move from 83 to 84, simply updating the version leaves the bindings broken. Hence why I didn't update the python bindings at all.
The failure to bump the protocol version for the perl bindings was an oversight.
comment:3 Changed 3 years ago by
| Status: | new → accepted |
|---|
comment:4 Changed 3 years ago by
Having carelessly created many orphans by deleting their files, I tried find_orphans.py
Python Backend Connection Backend has version 85, and we speak 83 Traceback (most recent call last):
File "find_orphans.py", line 222, in <module>
BE = MythBE(db=DB)
File "/usr/lib/python2.7/site-packages/MythTV/mythproto.py", line 119, in init
self._conn.command = self._newcmdconn()
I would like to be able to delete the missing recordings from 'Previously Recorded', too, but AFAIK that's not currently in the spec.
comment:5 Changed 2 years ago by
The python bindings uses the UPDATE_FILE_SIZE event which now uses recordid after [b220116f] but the bindings expect chanid/starttime.
See https://github.com/MythTV/mythtv/blob/master/mythtv/bindings/python/MythTV/mythproto.py#L533
Tested with: v0.28-pre-2572-gdba0fd9