Opened 9 years ago

Closed 7 years ago

Last modified 7 years ago

#12386 closed Patch - Feature (fixed)

Feature patch - Support User-Agent specification via QNetworkRequest to mythdownloadmanager

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: Gary Buhrmaster <gary.buhrmaster@…>
Priority: trivial Milestone: 29.0
Component: MythTV - General Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Feature patch to support the ability to specify the User-Agent for the headers to be passed to the target server (using a QNetworkRequest). The default is to use the existing (custom) MythTV User-Agent (i.e. no change unless requested by some future code addition).

To be honest, I do not know of a case where this is useful, today, but as some sites do generate various formats of response based on User-Agent, it may be useful for some future usage. And it was trivial to do (and I had my head in the mythdownloadmanager code for other reasons).

github ref: ​https://github.com/garybuhrmaster/mythtv/commit/c479db192d8ed827f597b77f6935b80dfe1f1afe
github git-am ref: ​https://github.com/garybuhrmaster/mythtv/commit/c479db192d8ed827f597b77f6935b80dfe1f1afe.patch

Change History (2)

comment:1 Changed 7 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Owner: set to Gary Buhrmaster <gary.buhrmaster@…>
Resolution: → fixed
Status: new → closed

In 36669f92cf612bcc61643757d68507af3f8f63eb/mythtv:

MythDownloadManager?: Support User-Agent passthrough. Fixes #12386

Signed-off-by: Paul Harrison <pharrison@…>

comment:2 Changed 7 years ago by paulh

Milestone: unknown → 29.0
Note: See TracTickets for help on using tickets.