Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#12414 closed Developer Task (Fixed)

[task] dbus based screensaver

Reported by: Stuart Auchterlonie Owned by: Stuart Auchterlonie
Priority: minor Milestone: 0.28
Component: MythTV - User Interface Library Version: 0.27.4
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Task to track replacing the XDPMS based screensaver with a DBUS based approach. The DPMS approach no longer seems to work at all

Attachments (2)

screensaver.tar.gz (1.1 KB) - added by Stuart Auchterlonie 5 years ago.
screensaver-v2.tar.gz (1.1 KB) - added by Stuart Auchterlonie 5 years ago.
v2 with updated includes

Download all attachments as: .zip

Change History (14)

Changed 5 years ago by Stuart Auchterlonie

Attachment: screensaver.tar.gz added

comment:1 Changed 5 years ago by Stuart Auchterlonie

I've added a test program which will inhibit the screensaver via dbus.

It works so far on f20/f21 with Qt4 and Qt5. Tests on other platforms wanted

comment:2 Changed 5 years ago by Stuart Auchterlonie

Status: newaccepted

Changed 5 years ago by Stuart Auchterlonie

Attachment: screensaver-v2.tar.gz added

v2 with updated includes

comment:4 Changed 5 years ago by Stuart Auchterlonie <stuarta@…>

In 7c18c182e693302915bfcdd483f95192c95c04f1/mythtv:

Refs #12414. Removes some old commented out code

comment:5 Changed 5 years ago by Stuart Auchterlonie <stuarta@…>

In 70ae25deab026238250cbe0ca108fb6ceb41e188/mythtv:

Fix lirc being ignored after dbus screen saver changes.

If the Screensaver is Asleep() we ignore all keypresses
generated via the remote. This is clearly so that a button
pressed on the remote while the screen is asleep only wakes
up the screen, rather than triggering an action.

This swaps the logic around in the dbus screensaver so that
it satisfies the Asleep() check.

We may need to revist this in the future if we find that
when using the dbus screensaver we are not ignoring the
remote keypress which is used to bring us out of screensave.

Fixes #12435
Refs #12414

comment:6 Changed 5 years ago by Stuart Auchterlonie

Type: Bug Report - GeneralDeveloper Task

comment:7 Changed 5 years ago by Stuart Auchterlonie <stuarta@…>

In b1c3c35a99fbd3498a01dc06888801b553604927/mythtv:

Separate the ScreenSaver? base class from the ScreenSaverController?.

This is a preliminary step to allow multiple screen saver control
methods to be utilized at the same time.

Refs #12438
Refs #12414

comment:8 Changed 5 years ago by Stuart Auchterlonie <stuarta@…>

In 348ed663810ffa6860f380733a677e0aa6d729d1/mythtv:

Move failure to connect to the different dbus services to LOG_WARNING level

Refs #12438
Refs #12414

comment:9 Changed 5 years ago by Stuart Auchterlonie <stuarta@…>

In e731ebc0d31d20afa29a95a3934be0149c2e0383/mythtv:

Move failure to connect to the different dbus services to LOG_WARNING level #2

Refs #12438
Refs #12414

comment:10 Changed 5 years ago by Stuart Auchterlonie <stuarta@…>

In 8ea5911f066fe406deeddb8ba92b629be4f47cd1/mythtv:

Re-Enable screensaver-x11 after the dbus screensaver support was added.

This now utilizes the dbus screensaver first, and then the previously
existing screensaver methods. This should resolve the issues seen by
those using only DPMS or xscreensaver.

Fixes #12438
Refs #12414

comment:11 Changed 4 years ago by Stuart Auchterlonie

Resolution: Fixed
Status: acceptedclosed

This is now all completed. Closing

comment:12 Changed 4 years ago by Stuart Auchterlonie <stuarta@…>

In 42939f201a653b8e66876ba88b2bcbc4b57511a2/mythtv:

Refs #12414. Removes some old commented out code

(cherry picked from commit 7c18c182e693302915bfcdd483f95192c95c04f1)

Backport to fixes/0.27. Refs #12511

Note: See TracTickets for help on using tickets.