Opened 9 years ago
Closed 8 years ago
Last modified 8 years ago
#12434 closed Patch - Bug Fix (fixed)
Grammar fix in Manage Recordings->Search Lists->New Titles
Reported by: | Owned by: | Nicolas Riendeau | |
---|---|---|---|
Priority: | minor | Milestone: | 0.28 |
Component: | Translations | Version: | 0.27-fixes |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
When you go to Manage Recordings->Search Lists->New Titles, the description says "Pick a program to record FOR a list of new titles". Shouldn't that be "Pick a program to record FROM a list of new titles"?
After posting that in the mailing list, Frank Phillips created a patch which I've attached here.
Attachments (1)
Change History (9)
Changed 9 years ago by
Attachment: | grammar-fix.patch added |
---|
comment:1 Changed 9 years ago by
Milestone: | unknown → 0.28 |
---|---|
Owner: | set to stuartm |
Status: | new → accepted |
comment:2 Changed 9 years ago by
Hi!
This touches the translation files and *should not* be applied as is.
Translation files must always be updated by our translators, fixing the problem in the source will fix the problem in the translation files (the strings to be translated are extracted by a tool which should only be run by our translators).
Thank you and have a nice day,
Nicolas
comment:3 Changed 9 years ago by
I have just noticed something else...
This also modify one of the themestrings.h files, this is also a file which is extracted/generated and should not normally be directly altered.
comment:4 Changed 8 years ago by
Component: | MythTV - General → Translations |
---|---|
Owner: | changed from stuartm to Nicolas Riendeau |
Status: | accepted → assigned |
Nicolas, assigning this to you as you had a look already. Can we/you pull in the four theme files with the grammar fix?
comment:5 Changed 8 years ago by
Status: | assigned → accepted |
---|
comment:6 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
comment:8 Changed 8 years ago by
I am only committing the changes to the theme files, the rest will get updated when we extract the theme strings (which should be done shortly) and translators submit their updates.
As I said before the translations and related files should never be patched in this way, they must be updated by our translators using the Qt tools and the themestrings.h file is generated and should be directly altered like this.
Thank you and have a nice day!
Nicolas
Frank Phillips' grammar patch for New Titles search