Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#12434 closed Patch - Bug Fix (fixed)

Grammar fix in Manage Recordings->Search Lists->New Titles

Reported by: Ian Evans <dheianevans@…> Owned by: Nicolas Riendeau
Priority: minor Milestone: 0.28
Component: Translations Version: 0.27-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When you go to Manage Recordings->Search Lists->New Titles, the description says "Pick a program to record FOR a list of new titles". Shouldn't that be "Pick a program to record FROM a list of new titles"?

After posting that in the mailing list, Frank Phillips created a patch which I've attached here.

Attachments (1)

grammar-fix.patch (24.5 KB) - added by Ian Evans <dheianevans@…> 5 years ago.
Frank Phillips' grammar patch for New Titles search

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by Ian Evans <dheianevans@…>

Attachment: grammar-fix.patch added

Frank Phillips' grammar patch for New Titles search

comment:1 Changed 5 years ago by stuartm

Milestone: unknown0.28
Owner: set to stuartm
Status: newaccepted

comment:2 Changed 5 years ago by Nicolas Riendeau

Hi!

This touches the translation files and *should not* be applied as is.

Translation files must always be updated by our translators, fixing the problem in the source will fix the problem in the translation files (the strings to be translated are extracted by a tool which should only be run by our translators).

Thank you and have a nice day,

Nicolas

comment:3 Changed 5 years ago by Nicolas Riendeau

I have just noticed something else...

This also modify one of the themestrings.h files, this is also a file which is extracted/generated and should not normally be directly altered.

comment:4 Changed 4 years ago by Karl Egly

Component: MythTV - GeneralTranslations
Owner: changed from stuartm to Nicolas Riendeau
Status: acceptedassigned

Nicolas, assigning this to you as you had a look already. Can we/you pull in the four theme files with the grammar fix?

comment:5 Changed 4 years ago by Nicolas Riendeau

Status: assignedaccepted

comment:6 Changed 4 years ago by Nicolas Riendeau <nriendeau@…>

Resolution: fixed
Status: acceptedclosed

In 369b7cc8d7b35bc0104fa6e2b8144ec75be1a7d5/mythtv:

Grammar fix in Manage Recordings->Search Lists->New Titles

Thanks goes to Ian Evans and Frank Phillips!

Closes #12434

comment:7 Changed 4 years ago by Nicolas Riendeau <nriendeau@…>

In 720ab5af563a7b411a6ee7e5cdd4786e58bd4ca4/mythtv:

Grammar fix in Manage Recordings->Search Lists->New Titles

Thanks goes to Ian Evans and Frank Phillips!

Closes #12434

comment:8 Changed 4 years ago by Nicolas Riendeau

I am only committing the changes to the theme files, the rest get update when we extract the theme strings (which should be done shortly) and translators submit their updates.

As I said before the translations and related files should never be patched in this way, they must be updated by our translators using the Qt tools and the themestrings.h file is generated and should be directly altered like this.

Thank you and have a nice day!

Nicolas

Version 0, edited 4 years ago by Nicolas Riendeau (next)
Note: See TracTickets for help on using tickets.