Opened 5 years ago

Closed 4 years ago

#12506 closed Patch - Bug Fix (fixed)

deterministic sort order for MythWeb message catalog

Reported by: blaz.lorger@… Owned by: Nicolas Riendeau
Priority: minor Milestone: 0.28
Component: Translations Version: Unspecified
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Message sort order implemented in build_translation.pl is not deterministic. On every execution script produces different message catalog because ordering of message keys that differ only in letter case is selected randomly.

This patch ensures that selected sort order is deterministic. Uppercase letter is always placed in front of corresponding lowercase letter.

Patch should be applied and used to reorder message catalog on all active branches to avoid merge conflict when message catalog is updated with build_translation.pl.

Attachments (1)

0001-Make-sure-string-sorting-in-message-catalog-is-deter.patch (1.2 KB) - added by blaz.lorger@… 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by blaz.lorger@…

comment:1 Changed 5 years ago by Karl Egly

Component: Plugin - MythWebTranslations
Owner: changed from Rob Smith to Nicolas Riendeau

Thank you for your contribution. I can reproduce the issue and the fix. Moving this over to Translations for consideration.

comment:2 Changed 4 years ago by Nicolas Riendeau

Milestone: unknown0.28
Status: newassigned

comment:3 Changed 4 years ago by Blaz Lorger <blaz.lorger@…>

Resolution: fixed
Status: assignedclosed

In c4f71a7ad6d92b3b1b4306ab3c0176b7a3729788/mythweb:

Deterministic sort order for MythWeb message catalog
from blaz.lorger@…

Thank you!

Closes #12506

Signed-off-by: Nicolas Riendeau <nriendeau@…>

Note: See TracTickets for help on using tickets.