Opened 4 years ago

Closed 4 years ago

#12542 closed Patch - Feature (Fixed)

Sky Germany EIT fixup for season and episode

Reported by: lomion@… Owned by: Karl Egly
Priority: minor Milestone: 0.28
Component: MythTV - EIT Version: 0.27.5
Severity: low Keywords:
Cc: Ticket locked: no

Description

Sky Germany sends season and episode numbers within the Description field.

Patch 1 removed the string from description and sets the season and episode numbers in the database: https://github.com/lomion0815/mythtv/commit/ff85c27842901a168b66e16dcfe7fa66da92aa81

Patch 2 provides these numbers in the ProgramInfo? for further usage: https://github.com/lomion0815/mythtv/commit/efc721375556a956baa5f76289611e31f5b8a62a

Patch 3 just fixes EIT-fixup for HD channels: https://github.com/lomion0815/mythtv/commit/dd548189d5874e29bb036a9c888fe89c894f6209

Hint: The season and episode number could be added to the programguide like this: https://github.com/lomion0815/blue-abstract-wide/commit/380e3cd6f72169b85f1035562994e6d9e584c88f

Attachments (1)

0004-unbreak-credits-year-fixup-for-Sky-Germany.patch (7.2 KB) - added by Karl Egly 4 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 4 years ago by lomion@…

Changed 4 years ago by Karl Egly

comment:2 Changed 4 years ago by Karl Egly

I started to pull the season/episode fixup into master and noticed that the format needed for the existing fixups appears to have changed. Can you verify that?

comment:3 Changed 4 years ago by Lomion0815 <lomion@…>

In ee15f34628e295a8fabef0a9bf1bbb0c21ef6cad/mythtv:

Extract Season and Episode from Description field for Sky Germany

Refs #12542
Patch by lomion@…

comment:4 Changed 4 years ago by Karl Dietz <dekarl@…>

In f6aa8e174513328f442e070ace72b6f898818c27/mythtv:

Unit tests for Sky episode EIT fixup

Refs #12542
Patch by lomion@…

Conflicts:

mythtv/libs/libmythtv/test/test_eitfixups/test_eitfixups.cpp
mythtv/libs/libmythtv/test/test_eitfixups/test_eitfixups.h

comment:5 Changed 4 years ago by Karl Dietz <dekarl@…>

In e85b848409e7e81a2f7bcc5f84ae447638bcceac/mythtv:

unbreak credits/year fixup for Sky Germany

Refs #12542

comment:6 Changed 4 years ago by lomion@…

I did some traces for the credits/year fixups and came up with this patch for the fixup and the unit tests. https://github.com/lomion0815/mythtv/commit/58208500cf37d0251dd57fd52371236c7da80be0

They transmit chars with hexcode 0x0a within the description string. I will test the fixups in the following days and will report back if they work correctly.

comment:7 Changed 4 years ago by Karl Egly

I'm closing this as I think all patches have been applied or superseded by #12702.

comment:8 Changed 4 years ago by Karl Egly

Milestone: unknown0.28
Resolution: Fixed
Status: newclosed
Note: See TracTickets for help on using tickets.