Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12571 closed Bug Report - General (Works for me)

Theme url does not exist for lastest git version 0.28-pre

Reported by: William L. DeRieux IV <williamderieux@…> Owned by: Stuart Auchterlonie
Priority: minor Milestone: 0.28
Component: Services - Theme Downloads Version: Master Head
Severity: high Keywords:
Cc: Ticket locked: no

Description

For 0.28-pre the theme url does not exist: http://themes.mythtv.org/themes/repository/0.28-pre/themes.zip

however this url does: http://themes.mythtv.org/themes/repository/trunk/themes.zip

The issue occurs at lines 233-235 of file mythtv/programs/mythfrontend/themechooser.cpp

QString themeSite = QString("%1/%2")
.arg(gCoreContext->GetSetting("ThemeRepositoryURL",
 "http://themes.mythtv.org/themes/repository")).arg(version);

I'm not sure if this was an oversight (someone forgot to create the page) or if the url should be pointing to trunk rather than 0.28-pre.

I set this ticket to high severity because anyone working with the git:master branch will be unable to download or test any themes.

Change History (9)

comment:1 Changed 4 years ago by paulh

Resolution: Invalid
Status: newclosed

It's working as it should be because until it's actually released there is no such version of 0.28 so master will use themes defined in http://themes.mythtv.org/themes/repository/trunk/themes.zip

comment:2 Changed 4 years ago by William L. DeRieux IV <williamderieux@…>

Resolution: Invalid
Status: closednew

What I'm saying is the it attempted to use the themes url as though 0.28 had been released, rather than using the trunk url.

comment:3 Changed 4 years ago by William L. DeRieux IV <williamderieux@…>

Further looking into the code in themechooser.cpp.

I think the real culprit is a hold-over from the days of svn and is expecting the BRNACH to be trunk instead of master. The git:master branch will never be trunk

line:191

 if (MythVersion == "trunk")
    {
        LoadVersion(MythVersion, themesSeen, true);
        LOG(VB_GUI, LOG_INFO, QString("Loading themes for %1").arg(MythVersion));
    }
    else
    {

        MythVersion = MYTH_BINARY_VERSION; // Example: 0.25.20101017-1
        MythVersion.replace(QRegExp("\\.[0-9]{8,}.*"), "");

comment:4 Changed 4 years ago by paulh

If you press menu on the main menu and select 'About' what is the version and branch shown as?

comment:5 in reply to:  3 Changed 4 years ago by paulh

Replying to William L. DeRieux IV <williamderieux@…>:

Further looking into the code in themechooser.cpp.

I think the real culprit is a hold-over from the days of svn and is expecting the BRNACH to be trunk instead of master. The git:master branch will never be trunk

line:191

 if (MythVersion == "trunk")
    {
        LoadVersion(MythVersion, themesSeen, true);
        LOG(VB_GUI, LOG_INFO, QString("Loading themes for %1").arg(MythVersion));
    }
    else
    {

        MythVersion = MYTH_BINARY_VERSION; // Example: 0.25.20101017-1
        MythVersion.replace(QRegExp("\\.[0-9]{8,}.*"), "");

Yes but earlier in the same function you have https://github.com/MythTV/mythtv/blob/master/mythtv/programs/mythfrontend/themechooser.cpp#L157

So master is treated as trunk.

comment:6 Changed 4 years ago by William L. DeRieux IV <williamderieux@…>

Well this is really weird (I was originally testing revision 218306f452f8bb24bbae14becd0c06275a141903)

I checkedout that revision on a fresh system running debian/sid (one that has never had mythtv installed) and the themes were downloaded/useable oob.

So to sum it up...

  • I can't re-produce the issue (on my dev system)...it must have been something left behind by an old install of 0.27.5 that was on my main desktop.

Paul, I guess you can go ahead and set this as invalid again.

comment:7 Changed 4 years ago by paulh

Resolution: Works for me
Status: newclosed

It would still be interesting to see the version and branch reported on the 'About' popup on the main menu since it prints the same string the theme chooser users to decide which branch we are on and thus which themes are valid.

I know in the past we have had problems with some distros messing with the version string that was causing problems.

comment:8 in reply to:  7 ; Changed 4 years ago by William L. DeRieux IV <williamderieux@…>

Replying to paulh:

It would still be interesting to see the version and branch reported on the 'About' popup on the main menu since it prints the same string the theme chooser users to decide which branch we are on and thus which themes are valid.

I know in the past we have had problems with some distros messing with the version string that was causing problems.

The reported branch was master

comment:9 in reply to:  8 Changed 4 years ago by William L. DeRieux IV <williamderieux@…>

Replying to William L. DeRieux IV <williamderieux@…>:

Replying to paulh:

It would still be interesting to see the version and branch reported on the 'About' popup on the main menu since it prints the same string the theme chooser users to decide which branch we are on and thus which themes are valid.

I know in the past we have had problems with some distros messing with the version string that was causing problems.

The reported branch was master

It just occurred to me why this happened on only my system (but not on the copy a compiled yesterday).... It's because the .git folder was missing -- as far as git was concerned I did not have valid git working copy.

That means version.sh would set MYTH_SOURCE_PATH to an empty string and MythVersion? never got set to trunk in themechooser.cpp.

I guess the simplest solution would be to modify line 157 in themechooser.cpp if MythVersion? is an empty string it should probably be set to trunk.

    // Treat devel branches as master
    if (MythVersion.isEmpty() || !MythVersion.startsWith("fixes/"))
        // FIXME: For now, treat git master the same as svn trunk
        MythVersion = "trunk";
Note: See TracTickets for help on using tickets.