Modify

Opened 2 years ago

Last modified 2 years ago

#12585 new Bug Report - General

tmdb3: Use searchMovieWithYear instead of searchMovie

Reported by: angela.schmid@… Owned by: jyavenard
Priority: minor Milestone: unknown
Component: MythTV - Video Library Version: 0.27.5
Severity: low Keywords: tmdb year
Cc: Ticket locked: no

Description

Use searchMovieWithYear instead of searchMovie so that an optional year in the query string is used to query tmdb.

For example "Star Wars (1977)", instead of "Star Wars"

Attachments (1)

0001-Use-searchMovieWithYear-instead-of-searchMovie.patch (1.3 KB) - added by angela.schmid@… 2 years ago.

Download all attachments as: .zip

Change History (3)

Changed 2 years ago by angela.schmid@…

comment:1 Changed 2 years ago by dekarl

Hmm, will this find "Blues Brothers 2000"? It sounds like it. So this would be preferable to the implementation in https://github.com/MythTV/mythtv/pull/103

Can you confirm that "Star Wars 1977.mkv" and "Blues Brothers 2000.mkv" both work as expected?

comment:2 Changed 2 years ago by angela.schmid@…

Yes it will. When it does not find "(xxxx)" at the end of the query string it uses the query string as is and calls searchMovie unchanged. In case it finds "(xxxx)" and xxxx is a valid date, it strips "(xxxx)" to be passed as the query and calls searchMovie with the additional year argument.

See mythtv/bindings/python/tmdb3/tmdb3/tmdb_api.py

Three years ago i removed the brackets and searched with "Blues Brothers 2000", but i got much better search results for query="Star Wars" and a separate year argument starting with tmdb v3.

Adapting the source to interprete 9999 at the end and checking for a valid year range will give better search results also for "Blues Brothers 2000".

After stripping the date away I would check if the query string is not empty, leaving all as is, in cases like the movie "2012".

Add Comment

Modify Ticket

Action
as new The owner will remain jyavenard.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.