Opened 8 years ago
Closed 4 years ago
#12585 closed Bug Report - General (Unverified)
tmdb3: Use searchMovieWithYear instead of searchMovie
Reported by: | Owned by: | JYA | |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | MythTV - Video Library | Version: | 0.27.5 |
Severity: | low | Keywords: | tmdb year |
Cc: | Ticket locked: | no |
Description
Use searchMovieWithYear instead of searchMovie so that an optional year in the query string is used to query tmdb.
For example "Star Wars (1977)", instead of "Star Wars"
Attachments (1)
Change History (4)
Changed 8 years ago by
Attachment: | 0001-Use-searchMovieWithYear-instead-of-searchMovie.patch added |
---|
comment:1 Changed 8 years ago by
comment:2 Changed 8 years ago by
Yes it will. When it does not find "(xxxx)" at the end of the query string it uses the query string as is and calls searchMovie unchanged. In case it finds "(xxxx)" and xxxx is a valid date, it strips "(xxxx)" to be passed as the query and calls searchMovie with the additional year argument.
See mythtv/bindings/python/tmdb3/tmdb3/tmdb_api.py
Three years ago i removed the brackets and searched with "Blues Brothers 2000", but i got much better search results for query="Star Wars" and a separate year argument starting with tmdb v3.
Adapting the source to interprete 9999 at the end and checking for a valid year range will give better search results also for "Blues Brothers 2000".
After stripping the date away I would check if the query string is not empty, leaving all as is, in cases like the movie "2012".
comment:3 Changed 4 years ago by
Resolution: | → Unverified |
---|---|
Status: | new → closed |
Closing all old tickets in trac.
If your issue still persists, please open an issue in Github https://github.com/MythTV/mythtv/issues
and reference the existing trac ticket.
Hmm, will this find "Blues Brothers 2000"? It sounds like it. So this would be preferable to the implementation in https://github.com/MythTV/mythtv/pull/103
Can you confirm that "Star Wars 1977.mkv" and "Blues Brothers 2000.mkv" both work as expected?