Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12615 closed Bug Report - General (fixed)

Build broken on non-V4L systems

Reported by: ctreleaven@… Owned by: JYA
Priority: minor Milestone: 0.28
Component: MythTV - Recording Version: Master Head
Severity: medium Keywords:
Cc: ctreleaven@…, Stuart Auchterlonie Ticket locked: no

Description

A recent commit has broken the build on systems that do not use/support Video4Linux, such as OS X.

Clang reports an error, as follows:

In file included from recordingprofile.cpp:2:
In file included from ./recordingprofile.h:7:
In file included from ./v4l2util.h:4:
./videodev2.h:61:10: fatal error: 'linux/ioctl.h' file not found
#include <linux/ioctl.h>
         ^
1 error generated.

The problem commit is:

https://github.com/MythTV/mythtv/commit/75888045e79622f4f2a51ab73bd5424579b6f520#diff-4ba1aebd1cc6d0f148bf3b4ee59acc69

Fix may be as simple as wrapping the include(s) in an #ifdef.

I suggest the Priority should be higher than the default with a release pending.

Change History (6)

comment:1 Changed 4 years ago by John Poet <jpoet@…>

Resolution: fixed
Status: newclosed

In 29d854117c240d771d90be4aefb962600f9be156/mythtv:

Fix compilation when V4L2 is disabled.

Fixes #12615

comment:2 Changed 4 years ago by ctreleaven@…

Thanks for the prompt attention but it still seems to be broken. I just updated to include the above commit and I get the following:

In file included from recordingprofile.cpp:9:
In file included from ./v4l2util.h:4:
./videodev2.h:61:10: fatal error: 'linux/ioctl.h' file not found
#include <linux/ioctl.h>
         ^

and

In file included from videosource.cpp:46:
In file included from ./v4l2util.h:4:
./videodev2.h:61:10: fatal error: 'linux/ioctl.h' file not found
#include <linux/ioctl.h>
         ^
1 error generated.

comment:3 Changed 4 years ago by John Poet <jpoet@…>

In eda27c684a90315d3936fb6df654f2d785d240f6/mythtv:

Hopefully fixes V4L2enc compilation on non-linux machines.

Fixes #12615

comment:4 Changed 4 years ago by Craig Treleaven <ctreleaven@…>

I confirm a successful build on OS X!

Thank you.

comment:5 Changed 4 years ago by paulh

Milestone: unknown0.28

comment:6 Changed 4 years ago by Stuart Auchterlonie

Cc: Stuart Auchterlonie added
Version: UnspecifiedMaster Head

I've committed 7032e51458a396b271c2cf4796a89ccc5401d3d9 to address the exact same issue on FreeBSD, however I suspect this will break the OSX build again.

Please let me know if it works or not after this change.

Regards Stuart

Note: See TracTickets for help on using tickets.