Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#12643 closed Bug Report - Crash (fixed)

Raspberry pi: Failure when resolution changes

Reported by: Peter Bennett <pgbennett@…> Owned by: JYA
Priority: major Milestone: 0.28
Component: MythTV - Video Playback Version: Master Head
Severity: medium Keywords: Raspberry pi
Cc: Ticket locked: no

Description

When the video resolution changes in a recording, e.g. from 528x480 to 1920x1080, when it gets to playing that point, the frontend shuts down with an assertion error message:

mythfrontend: privatedecoder_omx.cpp:562: OMX_ERRORTYPE PrivateDecoderOMX::FreeOutputBuffersCB(): Assertion `((OMX_BUFFERHEADERTYPE*)((frame)->priv[2])) == hdr' failed.

Attachments (1)

Ticket_12643_Fix_Resolution_change_crash.patch (2.6 KB) - added by Peter Bennett <pgbennett@…> 3 years ago.
Patch to fix this bug

Download all attachments as: .zip

Change History (9)

comment:1 Changed 3 years ago by Peter Bennett <pgbennett@…>

LVR supplied a partial patch for this. I completed the fix and I am currently testing it. I will attach a patch to this ticket once I am happy with the fix.

Changed 3 years ago by Peter Bennett <pgbennett@…>

Patch to fix this bug

comment:2 Changed 3 years ago by Peter Bennett <pgbennett@…>

I have attached the patch which fixes this problem. Most of the patch was from LVR. Reset was being called in the wrong place and resulting in buffers freed at the wrong time. Additionally fixes some incorrect assert calls.

comment:3 Changed 3 years ago by Stuart Auchterlonie

Milestone: unknown0.28

comment:4 Changed 3 years ago by Stuart Auchterlonie

Priority: minormajor

Patch looks okay to me. JYA can you review?

comment:5 Changed 3 years ago by JYA

Could you please provide a sample of the video that caused the original crash?

I want to check that it's not negatively affecting the Mac decoder...

comment:6 Changed 3 years ago by Peter Bennett <pgbennett@…>

I extracted the first 100 MB of the file (about 1 minute). The first 10 seconds is in 528x480 resolution and after that it changes to 1920x1080. The raspberry pi frontend would crash after the first 10 seconds.

https://www.dropbox.com/s/opw73suhkb3zumi/resolution_change.mpg?dl=0

comment:7 Changed 3 years ago by Peter Bennett <pgbennett@…>

Resolution: fixed
Status: newclosed

In 7fb92b9e59855b2534c71e7080c2fcbb723bc4fa/mythtv:

OpenMax?: Fix failure when resolution changes. Fixes #12643

comment:8 Changed 3 years ago by Peter Bennett <pgbennett@…>

In 6da9d39c064090948437734b5821f143a49ff488/mythtv:

OpenMax?: Fix failure when resolution changes. Fixes #12643

(cherry picked from commit 7fb92b9e59855b2534c71e7080c2fcbb723bc4fa)

Note: See TracTickets for help on using tickets.