Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12644 closed Bug Report - General (fixed)

Raspberry pi: Loses sound when skipping backwards

Reported by: Peter Bennett <pgbennett@…> Owned by: JYA
Priority: minor Milestone: 0.28
Component: MythTV - Video Playback Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

While playing a recording, and using left arrow to skip back 20 seconds, the video skips back correctly but the sound goes off for 20 seconds, i.e. the sound only comes back once you are back at the point you skipped from.

Attachments (2)

Ticket_12644_Fix_sound_when_skip_back.patch (2.5 KB) - added by Peter Bennett <pgbennett@…> 4 years ago.
Ticket_12644_Additional_logging.patch (3.4 KB) - added by Peter Bennett <pgbennett@…> 4 years ago.
Optional - Additional Debug logging for diagnosing the problem

Download all attachments as: .zip

Change History (8)

comment:1 Changed 4 years ago by Peter Bennett <pgbennett@…>

I have a fix for this bug. I am currently testing it and I will attach a patch once I am happy with it.

Changed 4 years ago by Peter Bennett <pgbennett@…>

Changed 4 years ago by Peter Bennett <pgbennett@…>

Optional - Additional Debug logging for diagnosing the problem

comment:2 Changed 4 years ago by Peter Bennett <pgbennett@…>

I have attached a patch that fixes the problem. There is also a patch that adds extra debug logging. I recommend installing this as well, but it is not necessary.

When there is a reset, such as a skip backward, it is not processed directly, but rather a flag is set to cause the reset to be processed the next time a packet is received. What was happening is that the reset was processed and timings cleared out, than that packet was processed, setting the audio and video timings again to the pre-skip values. Audio packets received after this were skipped because the code assumed they were prior to the start point. The fix is to discard the packet that was received at the time of the reset. The next packet contains the post-skip values and everything proceeds normally.

comment:3 Changed 4 years ago by Stuart Auchterlonie

Milestone: unknown0.28

comment:4 Changed 4 years ago by Stuart Auchterlonie

Patch looks okay to me. JYA can you review?

comment:5 Changed 4 years ago by Peter Bennett <pgbennett@…>

Resolution: fixed
Status: newclosed

In 6c8c5dfac9333954ddca28de3c20f7e18d10353f/mythtv:

Fix loss of sound when skipping backwards with OpenMax?. Fixes #12644

comment:6 Changed 4 years ago by Peter Bennett <pgbennett@…>

In 49473a4cbcf502f6b05adf9972943316fa614369/mythtv:

Fix loss of sound when skipping backwards with OpenMax?. Fixes #12644

Note: See TracTickets for help on using tickets.