Opened 13 years ago

Closed 13 years ago

#1268 closed patch (fixed)

Unable to create overrides for custom record programs

Reported by: derek@… Owned by: xris
Priority: minor Milestone: unknown
Component: mythweb Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Just pasting the email thread from the dev list...

====================

> Basically, what happened was that I noticed the hockey game I was
> recording was going to run late and for the first time I was going to
> take advantage of the ability to extend an in-progress recording.  I
> went to MythWeb and didn't see an option to do it so I did it from my
> frontend machine.  I noticed that the way the recording is extended is
> to add an override.  With that in mind I then went to MythWeb just to
> try it from there (now that I knew it was nothing more than an override
> to be created).
>
> When I select the program it loads the details page, but the override
> options are not presented, instead I get a message in red at the top
> saying, "This program is already scheduled to be recorded via a custom
> search."
>
> The display of the override options is suppressed by the if block
> starting at line 44 of modules/tv/detail.php.  This if block prints the
> red message and unsets the $schedule variable.  With $schedule set to
> NULL, the override options are suppressed.
>
> I was going to just create a new recording rule with the extended
> recording time, but wasn't sure if that was going to work (nor did I
> try it in fear of messing up the in-progress recording).

Could you please post this as a bug at http://svn.mythtv.org?  It'll
remind me to check with the other devs to figure out the proper method
of doing an override like this.

Attachments (1)

search_override.patch (6.6 KB) - added by derek@… 13 years ago.
Allow overrides for search based recording rules

Download all attachments as: .zip

Change History (3)

comment:1 Changed 13 years ago by derek@…

Type: defectpatch

The attached patch provides the ability to override serach-based recordings.

Summary of changes:

themes/default/tv/detail.php:

Modify available recording options based on the type of rule we're dealing with.

includes/recording_schedules.php:

Add 'parentid' property to Schedule class; modify SQL statement in save() method of Schedule class to update the parentid property.

modules/tv/detail.php:

Remove block that skips and ignores custom search rules; when creating an override set the parentid to that of the recid we're overriding; always set the search type to '0' for overrides.

Changed 13 years ago by derek@…

Attachment: search_override.patch added

Allow overrides for search based recording rules

comment:2 Changed 13 years ago by xris

Resolution: fixed
Status: newclosed

(In [9194]) apply heavily modified patch to close #1268. I've also done some cleanup of html to add <label> tags

Note: See TracTickets for help on using tickets.