Opened 8 years ago
Closed 6 years ago
Last modified 6 years ago
#12685 closed Patch - Feature (fixed)
Feature Patch: Properly detect CableCARD in Ceton tuner in cardutil.cpp
Reported by: | Owned by: | Peter Bennett | |
---|---|---|---|
Priority: | minor | Milestone: | 30.0 |
Component: | MythTV - General | Version: | Master Head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
"DO" the "TODO FIXME" in cardutil.cpp to properly detect if a CableCARD is inserted into a Ceton InfiniTV tuner (rather than just presume it is inserted, which is what the FIXME code did).
This code (as the HDHR code above it) leverages the existing approaches from the recorder specific handlers (i.e. most of the credit to others)
Lightly tested in master in a distant environment using remote smart hands to remove/insert a CableCARD into a Ceton InfiniTV for testing. Worked as expected.
As most people purchasing a Ceton InfiniTV tuner likely use a CableCARD, this update is likely a no-op for most.
Submitted as a feature, and not a bug, patch.
github ref: https://github.com/garybuhrmaster/mythtv/commit/08057e670dfa193793c8ceddf911328379b06b2b
github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/08057e670dfa193793c8ceddf911328379b06b2b.patch
Change History (9)
comment:1 Changed 8 years ago by
Milestone: | unknown → 0.29 |
---|
comment:2 Changed 8 years ago by
Milestone: | 0.29 → 29.0 |
---|
comment:3 Changed 8 years ago by
See also #12756 which provides a likely desirable (but not required) improvement for channel inserts after this patch.
comment:4 Changed 6 years ago by
Owner: | set to Peter Bennett |
---|---|
Status: | new → assigned |
comment:5 Changed 6 years ago by
Status: | assigned → accepted |
---|
comment:6 Changed 6 years ago by
I tested on my Ceton eth6, this fix and #12756 together:
- Cablecard inserted, mythfilldatabase inserts channels.
- Cablecard removed, mythfilldatabase does not insert channels.
- Watching LiveTV is ok while running mythfilldatabase to prove that cablecard detection does not disrupt recordings in progress.
- Checked that added channel can be watched.
comment:7 Changed 6 years ago by
Milestone: | 29.0 → 30.0 |
---|
comment:8 Changed 6 years ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
comment:9 Changed 6 years ago by
Owner: | changed from Peter Bennett to Peter Bennett |
---|
Milestone renamed