Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12693 closed Bug Report - General (fixed)

Raspberry pi: Background shows through with ffmpeg & openmax

Reported by: Peter Bennett <pgbennett@…> Owned by: JYA
Priority: minor Milestone: 0.28
Component: MythTV - Video Playback Version: Master Head
Severity: medium Keywords: Raspberry pi
Cc: Ticket locked: no

Description

The fix for ticket #12691 addressed the case where the decoder was openmax but does not cover the case where the decoder is ffmpeg and the renderer is openmax. The bleed through still happens in that case.

Using ffmpeg decoder and openmax renderer is a viable case and provides in some cases better quality than openmax decoder.

Attachments (2)

ticket_12693.patch (1.6 KB) - added by Peter Bennett <pgbennett@…> 4 years ago.
Fix for this ticket
ticket_12693_revised.patch (2.4 KB) - added by Peter Bennett <pgbennett@…> 4 years ago.
Revised patch file

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by Peter Bennett <pgbennett@…>

Attachment: ticket_12693.patch added

Fix for this ticket

Changed 4 years ago by Peter Bennett <pgbennett@…>

Attachment: ticket_12693_revised.patch added

Revised patch file

comment:1 Changed 4 years ago by Peter Bennett <pgbennett@…>

Please disregard the original patch file (ticket_12693.patch) and use the revised patch file (ticket_12693_revised.patch) to fix this. The revised patch implements the "GetName?()" strategy recommended by Roger Siddons, and also fixes the segmentation fault that occurred when viewing a video if the video file was missing.

comment:2 Changed 4 years ago by Peter Bennett <pgbennett@…>

Resolution: fixed
Status: newclosed

In ed3741d166a72ea5674ff5604a0e78dc7dda47a8/mythtv:

Pi: Background shows through with ffmpeg & openmax

aa676f77 prevented background bleed where the decoder was openmax
but does not cover the case where the decoder is ffmpeg and the renderer is openmax,
which still bleeds through. This is a viable combination which provides better quality
than openmax decoder in some cases.

Also fixes a segfault documented by #12700 & #12709, which was introduced by the fix for #12691.

Fixes #12693

Signed-off-by: Roger Siddons <rsiddons@…>

comment:3 Changed 4 years ago by Peter Bennett <pgbennett@…>

In 4bcc1005cafcc28fce9728394dfffc0320bb4d33/mythtv:

Pi: Background shows through with ffmpeg & openmax

aa676f77 prevented background bleed where the decoder was openmax
but does not cover the case where the decoder is ffmpeg and the renderer is openmax,
which still bleeds through. This is a viable combination which provides better quality
than openmax decoder in some cases.

Also fixes a segfault documented by #12700 & #12709, which was introduced by the fix for #12691.

Fixes #12693

Signed-off-by: Roger Siddons <rsiddons@…>
(cherry picked from commit ed3741d166a72ea5674ff5604a0e78dc7dda47a8)

Note: See TracTickets for help on using tickets.