Opened 13 years ago

Closed 13 years ago

#1271 closed patch (fixed)

register commercial-skip and audio-sync-adjustment key bindings

Reported by: Robert Tsai <rtsai1111> Owned by: cpinkham
Priority: trivial Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

TOGGLEAUDIOSYNC is not registered in the TV Playback key bindings; this patch registers a key binding for it. I chose "Y" because I *think* playing back recordings ought to be disjoint with live TV, but I might be wrong, in which case a different default key should be used. I'm a little confused here because some actions (e.g., SIGNALMON) verify the "in Live TV" state before doing anything, while others that seem non-Live-TV-ish don't similarly validate their state (QUEUETRANCODE, SPEEDINC, etc.).

This patch also adds a new CYCLECOMMSKIP action and registers a key binding for it. I chose 'R' because I think LiveTV and Recorded TV playback should be able to re-use keys without colliding with each other, but maybe the "real-time" commercial flagging enables comm-skipping during LiveTV, in which case something other than "R" should be chosen.

I also do a little bit of cleanup; the "commercialskipmethod" variable appears to be unused ...

Attachments (2)

mythtv.bindkeys.diff (6.2 KB) - added by Robert Tsai <rtsai1111> 13 years ago.
mythtv.bindkeys.2.diff (6.6 KB) - added by Robert Tsai <rtsai1111> 13 years ago.
also update keys.txt

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by Robert Tsai <rtsai1111>

Attachment: mythtv.bindkeys.diff added

Changed 13 years ago by Robert Tsai <rtsai1111>

Attachment: mythtv.bindkeys.2.diff added

also update keys.txt

comment:1 Changed 13 years ago by Isaac Richards

Owner: changed from Isaac Richards to cpinkham

comment:2 Changed 13 years ago by cpinkham

Resolution: fixed
Status: newclosed

(In [9188]) Add keybindings for toggling the audio sync adjustment controls and for cycling through the commercial skip modes (auto/on, off, notify). Closes #1271 by applying patch by Robert Tsai.

Note: See TracTickets for help on using tickets.