Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12729 closed Patch - Feature (fixed)

Feature patch: Update tables related to program tables

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: Karl Egly
Priority: minor Milestone: 29.0
Component: MythTV - EIT Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Feature patch: Update tables related to program tables

In the case that a program is deleted or moved, insure that related rating and genres rows are also deleted/moved. Not doing so can, in theory, leave "stale" data to be misinterpreted for some future program that occupies the same channel and start time. The added code (essentially) duplicates the previous lines of code dealing with the credits table.

The code segments updated (delete_program and change_program) appear to only be called from EIT related processing, and from a perusal of the codes, there does not appear to be any usual path that EIT will fill in these tables, so the only situation where this code might have impact would be someone using a mixture of xmltv source data and EIT (or, perhaps, moving from xmltv to EIT sources). While mixing sources of guide data is often a bad idea, that does not mean it can not occur. In any case, there appears to be no downside of just doing the right thing and updating the related tables when deleting/moving a program.

It should be noted that mythutil --cleareit clears out the programgenres and programrating tables, so this patch is consistent with the code of that program.

This patch has only been (lightly) tested by manual database manipulation as no (known to me) source will fill in all the tables at this time for real life testing. Perhaps the dev that eventually reviews this patch will have better luck with test cases.

github ref: https://github.com/garybuhrmaster/mythtv/commit/74a1b214a838a7e2429da6eb89758eef20d1f963

github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/74a1b214a838a7e2429da6eb89758eef20d1f963.patch

Change History (2)

comment:1 Changed 4 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: fixed
Status: newclosed

In 3865f57c1aeb7fd7615a6143357aa41fe36f43b9/mythtv:

Update tables related to the program table

In the case that a program is deleted or changed, insure
that the related programrating and programgenres tables
are also modified appropriately (as is the credits table)

Fixes #12729
Refs #12592

(cherry picked from commit 74a1b214a838a7e2429da6eb89758eef20d1f963)
Signed-off-by: Karl Dietz <dekarl@…>

comment:2 Changed 4 years ago by Karl Egly

Milestone: unknown29.0
Note: See TracTickets for help on using tickets.