Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#12745 closed Patch - Feature (fixed)

Feature patch: Insert ratings collected from (future) EIT parsing

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: Karl Egly
Priority: minor Milestone: 29.0
Component: MythTV - EIT Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Feature patch: Insert ratings from (a theoretical) EIT parsing and collection

There was some discussion in the irc logs about an interest in parsing the EIT data to provide and insert program ratings into the DB. Currently, the EIT InsertDB routine does not insert ratings, even if they were somehow collected into the DBEvent.

[I was looking at the program codes in this area for other reasons (see ticket #12742), but observed this case]

This feature patch will insert any parsed/obtained ratings into the programrating table should they be available in some future EIT parsing update elsewhere.

The inserted lines in programdata.cpp are copy/pasted from ProgInfo::InsertDB starting at ~1223 to DBEvent::InsertDB line ~1051.

This patch has only had limited testing. As no current EIT code parses and collects ratings in the DBEvent, there is nothing to actually insert at this time. But this patch enables the next steps.

github ref: https://github.com/garybuhrmaster/mythtv/commit/0329912388aa5cf4d2a0baffcf0dff925d8833f6

github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/0329912388aa5cf4d2a0baffcf0dff925d8833f6.patch

Change History (2)

comment:1 Changed 3 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: fixed
Status: newclosed

In 525bf8ab04c2f1c48799d297aabfa703609f7d53/mythtv:

Insert any program ratings available from (future) EIT parsing

Fixes #12745

(cherry picked from commit 0329912388aa5cf4d2a0baffcf0dff925d8833f6)

Signed-off-by: Karl Dietz <dekarl@…>

comment:2 Changed 3 years ago by Karl Egly

Milestone: unknown29.0
Note: See TracTickets for help on using tickets.