Opened 3 years ago

Closed 3 years ago

Last modified 14 months ago

#12746 closed Patch - Bug Fix (fixed)

CEC Fixes and raspberry Pi support

Reported by: Peter Bennett <pgbennett@…> Owned by: Peter Bennett
Priority: minor Milestone: 0.28.1
Component: MythTV - libCEC Version: 0.28.0
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Raspberry Pi has built in CEC support, which was not working with MythTV.

The following is fixed in this patch:

  1. Add the missing initialization call to InitVideoStandalone?(), which is supposed to be always called on initialization, but some systems work without it being called.
  2. Fix the destructor code which was hanging the frontend when you exit the frontend. This affects all systems using CEC not only raspberry pi.
  3. Add support for the TV Menu button calling the MythTV menu. This only works with some TV's. This also affects all systems, not just raspberry pi.
  4. Change the keycode for Play from P to Ctrl-P. Having both Pause and Play map to P is restrictive, since some TV sets only allow as few as 11 buttons to be passed through, this will allow mapping pause to something else, like info or menu, which the TV remote does not provide. This also affects all systems, not just raspberry pi.

I have tested this successfully on Raspberry Pi with 2 brands on TV with CEC.

I would appreciate it if somebody can test this patch on a desktop system with Pulse-Eight CEC adaptor to make sure that still works there.

Attachments (1)

Ticket_2746_Fix_CEC.patch (3.4 KB) - added by Peter Bennett <pgbennett@…> 3 years ago.
Patch to fix CEC support

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by Peter Bennett <pgbennett@…>

Attachment: Ticket_2746_Fix_CEC.patch added

Patch to fix CEC support

comment:1 Changed 3 years ago by Nicolas Riendeau

Hi Peter!

I tried it with my Pulse-Eight CEC adapter...

As I said on IRC it makes things better and it no longer hangs when I exit the frontend.

As far as being able to use my TV remote it is not possible right now, only a few keys are currently recognized by MythTV (left, right and exit IIRC), If I use their provided cec-client I see that a lot more keys could be processed (up, down, OK, red button, green button, yellow button, blue button, forward, backward, stop, play, pause).

My TV, a LG 60LM7200 IIRC, thinks that MythTV is a BD-R player in it's SimpLink? (LG name for CEC) memu...

Thank you and have a nice day!

Nicolas

comment:2 Changed 3 years ago by Peter Bennett

Owner: changed from Raymond Wagner to Peter Bennett
Status: newaccepted

comment:3 Changed 3 years ago by Peter Bennett <pbennett@…>

Resolution: fixed
Status: acceptedclosed

In c5e27122bd5cd1b1c673e38cc78af0e9d8e63521/mythtv:

Fix CEC bugs and add raspberry pi support for CEC

Fixes #12746

comment:4 Changed 3 years ago by Peter Bennett <pbennett@…>

In a40a63be116126034fc245f9713d1e84035f4f2d/mythtv:

Fix CEC bugs and add raspberry pi support for CEC

Fixes #12746

(cherry picked from commit c5e27122bd5cd1b1c673e38cc78af0e9d8e63521)

comment:5 Changed 14 months ago by Peter Bennett

Owner: changed from Peter Bennett to Peter Bennett
Note: See TracTickets for help on using tickets.