Opened 8 years ago
Closed 8 years ago
#12763 closed Bug Report - General (Fixed)
Themechooser parses version number incorrectly
Reported by: | Owned by: | Karl Egly | |
---|---|---|---|
Priority: | minor | Milestone: | 0.28.1 |
Component: | MythTV - General | Version: | 0.28.0 |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
I have mythtv version v0.28-61-g5af4b41 and the backend displays 61 error messages when it starts up:
2016-05-10 11:21:09.927411 I Running HouseKeeperTask 'ThemeUpdateNotifications'. 2016-05-10 11:21:09.927471 I Loading themes for 0.28 2016-05-10 11:21:10.776129 I Loading themes for 0.28.61 2016-05-10 11:21:10.976677 I HouseKeeper: Failed to download http://themes.mythtv.org/themes/repository/0.28.61/themes.zip remote themes info package.
That 0.28.61 messages are repeated with numbers going down to 0.28.1. This seems to be caused by parsing the "-61" in the version string as if it was ".61" This will likely also affect the front end, which duplicates some code.
mythtv/programs/mythfrontend/themechooser.cpp#L202
mythtv/programs/mythbackend/backendhousekeeper.cpp#L366
Also it would be good to refactor the code so that it is not duplicated.
Change History (7)
comment:1 Changed 8 years ago by
comment:3 Changed 8 years ago by
Milestone: | unknown → 0.28.1 |
---|---|
Owner: | set to Karl Egly |
Status: | new → accepted |
No point in porting to 0.27 (if its even an issue there) as the bug is only between 0.27 and 0.27.1 and that has long been released, so a fix will only make it into a version that doesn't trigger the bug.
comment:5 Changed 8 years ago by
Status: | accepted → infoneeded |
---|
Peter, can you confirm this as fixed?
I only run master and its nicely saying "I HouseKeeping? backendhousekeeper.cpp:380 (DoRun?) Loading themes for trunk" on startup
comment:6 Changed 8 years ago by
Karl Yes this is fixed. I have not seen that error in 4 months, since you made that fix.
comment:7 Changed 8 years ago by
Resolution: | → Fixed |
---|---|
Status: | infoneeded → closed |
In f4a8cf1673dcbaa649e3879b8716d3942474f2dd/mythtv: