Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#12784 closed Bug Report - General (Fixed)

mythtv-setup does not correctly url encode the channel icon searches

Reported by: Stuart Auchterlonie Owned by: Stuart Auchterlonie
Priority: minor Milestone: 0.28.1
Component: MythTV - Mythtv-setup Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

mythtv-setup does not correctly url encode the channel icon searches

This leads to channels with names such as "A&E..." being split by the url parser on the new services backend.

Attachments (1)

ticket12784-correct-url-encoding.diff (1.1 KB) - added by Stuart Auchterlonie 3 years ago.
Fix encoding of icon requests

Download all attachments as: .zip

Change History (12)

Changed 3 years ago by Stuart Auchterlonie

Fix encoding of icon requests

comment:1 Changed 3 years ago by stuartm

Patch looks good, if you ignore the whole CSV mess ;)

comment:2 Changed 3 years ago by Stuart Auchterlonie <stuarta@…>

In 5ca70de8cb80ff0986c0f11d787037c839ec0f08/mythtv:

Refs #12784. Properly url encode channel icon search requests

comment:3 Changed 3 years ago by Stuart Auchterlonie <stuarta@…>

In 2bc48044b2d73e76e7db2c43a0af3cdc497c83c9/mythtv:

Refs #12784. Properly url encode channel icon search requests, part 2

comment:4 Changed 3 years ago by Stuart Auchterlonie <stuarta@…>

In 28e95d81fc8a923e54b690ea93e0eea548ac5b51/mythtv:

Refs #12784. Properly url encode channel icon search requests

Signed-off-by: Stuart Auchterlonie <stuarta@…>

comment:5 Changed 3 years ago by Stuart Auchterlonie <stuarta@…>

In 23eba051c66de40375528718f8eb74ff72f625ca/mythtv:

Refs #12784. Properly url encode channel icon search requests, part 2

Signed-off-by: Stuart Auchterlonie <stuarta@…>

comment:6 Changed 3 years ago by Stuart Auchterlonie <stuarta@…>

In b7df821e20bf7bc730ae499abab4fdabb1390192/mythtv:

Refs #12784. Properly url encode channel icon search requests

Signed-off-by: Stuart Auchterlonie <stuarta@…>

comment:7 Changed 3 years ago by Stuart Auchterlonie <stuarta@…>

In fe0d343d5250cf0fe922817e80243020e2e3678d/mythtv:

Refs #12784. Properly url encode channel icon search requests, part 2

Signed-off-by: Stuart Auchterlonie <stuarta@…>

comment:8 Changed 3 years ago by Stuart Auchterlonie

Resolution: Fixed
Status: newclosed

Fixed in master, 0.28 and 0.27

comment:9 Changed 3 years ago by Stuart Auchterlonie <stuarta@…>

In 157da548ac483a01076de17fa6153068dca5cff9/mythtv:

Revert "Refs #12784. Properly url encode channel icon search requests, part 2"

This reverts commit 2bc48044b2d73e76e7db2c43a0af3cdc497c83c9.

This didn't actually do what it was meant to do

comment:10 Changed 3 years ago by Stuart Auchterlonie <stuarta@…>

In 22d3a1c3d75461393a9eb867b642dc4bdffb920a/mythtv:

Revert "Refs #12784. Properly url encode channel icon search requests, part 2"

This reverts commit 23eba051c66de40375528718f8eb74ff72f625ca.

This didn't actually do what it was meant to do.

comment:11 Changed 3 years ago by Stuart Auchterlonie <stuarta@…>

In a706ae1557eb9c482688b62afcfaaaa90218d2d2/mythtv:

Revert "Refs #12784. Properly url encode channel icon search requests, part 2"

This reverts commit fe0d343d5250cf0fe922817e80243020e2e3678d.

This didn't actually do what it was meant to do.

Note: See TracTickets for help on using tickets.