Opened 2 years ago

Last modified 16 months ago

#12805 assigned Bug Report - Crash

Plugin MythMusic crashes on a specific WMA file

Reported by: waynemcdougall@… Owned by: JYA
Priority: minor Milestone: unknown
Component: Plugin - MythMusic Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Playing one of my WMA files causes a segfault in mythfrontend after 5 seconds of playing. Nothing obviously wrong I can spot with the file. Pressing I on the file in mythMusic brings up all the metadata correctly.

I suspect the embedded album art.

Last time I had a problem with one file https://code.mythtv.org/trac/ticket/12403 the fantastic Paul Harrison fixed it very quickly once he had the file in hand. So rather than attaching a trace, I'm linking to the file.

http://codeworks.gen.nz:81/tt/bug.wma

This file has caused crashes for a long time. So it's not due to a recent change. It's taken me a while to track down as the place in the playlist is forgotten so I had to catch it happening.

Attachments (2)

version.txt (937 bytes) - added by Wayne McDougall 2 years ago.
Version
valgrind.log (70.7 KB) - added by paulh 17 months ago.

Download all attachments as: .zip

Change History (5)

Changed 2 years ago by Wayne McDougall

Attachment: version.txt added

Version

comment:1 Changed 17 months ago by paulh

Owner: changed from paulh to JYA
Status: newassigned

Sorry for the delay looking at this.

With the help of valgrind I've traced the problem to the audio buffer being over written causing random crashes.

It seem the value of MAX_SIZE_BUFFER here https://github.com/MythTV/mythtv/blob/master/mythtv/libs/libmyth/audio/audiooutput.h#L180 is too low for this particular file.

Doubling the size of MAX_SIZE_BUFFER stops the crash but the audio output code should not be over running the buffer and causing a crash.

Reassigning to jya to decide the best way to fix this.

Changed 17 months ago by paulh

Attachment: valgrind.log added

comment:2 Changed 16 months ago by Paul Harrison <pharrison@…>

In 783d36a9245efc77ae042d95a82d79e39f36225d/mythtv:

MythMusic: double the maximum size of the buffer used with DecodeAudio?

This is a temporary fix to at least allow the track in the ticket to play
without crashing. Refs #12805.

comment:3 Changed 16 months ago by Paul Harrison <pharrison@…>

In b1586b00d7f286a044589d46d4eebc50b1358ca8/mythtv:

MythMusic: double the maximum size of the buffer used with DecodeAudio?

This is a temporary fix to at least allow the track in the ticket to play
without crashing. Refs #12805.

(cherry picked from commit 783d36a9245efc77ae042d95a82d79e39f36225d)

Note: See TracTickets for help on using tickets.