Opened 8 years ago
Closed 4 years ago
#12805 closed Bug Report - Crash (Fixed)
Plugin MythMusic crashes on a specific WMA file
Reported by: | Owned by: | paul-h | |
---|---|---|---|
Priority: | minor | Milestone: | 0.28 |
Component: | Plugin - MythMusic | Version: | Master Head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Playing one of my WMA files causes a segfault in mythfrontend after 5 seconds of playing. Nothing obviously wrong I can spot with the file. Pressing I on the file in mythMusic brings up all the metadata correctly.
I suspect the embedded album art.
Last time I had a problem with one file https://code.mythtv.org/trac/ticket/12403 the fantastic Paul Harrison fixed it very quickly once he had the file in hand. So rather than attaching a trace, I'm linking to the file.
http://codeworks.gen.nz:81/tt/bug.wma
This file has caused crashes for a long time. So it's not due to a recent change. It's taken me a while to track down as the place in the playlist is forgotten so I had to catch it happening.
Attachments (2)
Change History (7)
Changed 8 years ago by
Attachment: | version.txt added |
---|
comment:1 Changed 7 years ago by
Owner: | changed from paulh to JYA |
---|---|
Status: | new → assigned |
Sorry for the delay looking at this.
With the help of valgrind I've traced the problem to the audio buffer being over written causing random crashes.
It seem the value of MAX_SIZE_BUFFER here https://github.com/MythTV/mythtv/blob/master/mythtv/libs/libmyth/audio/audiooutput.h#L180 is too low for this particular file.
Doubling the size of MAX_SIZE_BUFFER stops the crash but the audio output code should not be over running the buffer and causing a crash.
Reassigning to jya to decide the best way to fix this.
Changed 7 years ago by
Attachment: | valgrind.log added |
---|
comment:4 Changed 4 years ago by
Owner: | changed from JYA to paul-h |
---|
Paul, do we still need to do anything on this?
comment:5 Changed 4 years ago by
Milestone: | unknown → 0.28 |
---|---|
Resolution: | → Fixed |
Status: | assigned → closed |
Closing as fixed
Version