Opened 18 years ago
Closed 18 years ago
#1284 closed patch (fixed)
osx-packager.pl can't find mythtv.pro myththemes.pro and mythplugins.pro
Reported by: | Owned by: | Nigel | |
---|---|---|---|
Priority: | major | Milestone: | unknown |
Component: | mythtv | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
The code in the osxpackager script doesn't look at the full path for the $comp.pro, so it does not find the files, and doesn't build anything. patch is attached.
$ cat /tmp/osx-packager.pl.patch Index: contrib/osx-packager.pl =================================================================== --- contrib/osx-packager.pl (revision 8954) +++ contrib/osx-packager.pl (working copy) @@ -704,7 +704,7 @@ { my $compdir = "$svndir/$comp/" ; - if ( ! -e "$comp.pro" ) + if ( ! -e "$compdir/$comp.pro" ) { &Complain("$compdir/$comp.pro does not exist.", 'You must be building really old source?');
Attachments (1)
Change History (3)
Changed 18 years ago by
Attachment: | osx-packager.pl.patch added |
---|
comment:1 Changed 18 years ago by
Status: | new → assigned |
---|
Do'h. I originally has the if before the chdir, and did a last minute tidyup before checkin. Bad Nigel.
Of course, head SVN is currently broken due to other Mac changes, but --svnrev 8952 should be good.
comment:2 Changed 18 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Have checked in the fix. The changes I am making in SVN may cause broken builds for a while, so if anyone really needs to build the latest source, adding --disable-mac-accel to mythtv's configure (line 416 of osx-packager.pl) should ignore the incomplete or broken code. In fact, maybe that should be the default for now
svn diff patch.