Opened 8 years ago
Closed 4 years ago
#12848 closed Bug Report - General (Fixed)
DVB channel scan generates negative channel numbers
Reported by: | Owned by: | JYA | |
---|---|---|---|
Priority: | minor | Milestone: | 31.0 |
Component: | MythTV - Mythtv-setup | Version: | Master Head |
Severity: | low | Keywords: | DVB channel scan negative |
Cc: | Ticket locked: | no |
Description
Scanning DVB channels sometimes generates negative channel numbers, which I don't think is right
Attachments (1)
Change History (2)
Changed 8 years ago by
Attachment: | 07_chanid.diff added |
---|
comment:1 Changed 4 years ago by
Milestone: | unknown → 31.0 |
---|---|
Resolution: | → Fixed |
Status: | new → closed |
The negative channel numbers were apparently created by the minus sign between the freqid and the serviceid; when the freqid was empty the result is a negative serviceid value.
This is the code segment in channelscan_sm.cpp in today's master:
if ((info.m_si_standard == "mpeg") || (info.m_si_standard == "scte") || (info.m_si_standard == "opencable")) { if (info.m_freqid.isEmpty()) info.m_chan_num = QString("%1-%2") .arg(info.m_source_id) .arg(info.m_service_id); else info.m_chan_num = QString("%1-%2") .arg(info.m_freqid) .arg(info.m_service_id); }
The freqid is now only used to create the chan_num when freqid is not empty. This is equivalent to the patch in file 07_chanid.diff. Problem solved, ticket closed.
Note: See
TracTickets for help on using
tickets.
patch to skip freqid if length is zero