Opened 3 years ago

Closed 4 days ago

#12848 closed Bug Report - General (Fixed)

DVB channel scan generates negative channel numbers

Reported by: dag@… Owned by: JYA
Priority: minor Milestone: 31.0
Component: MythTV - Mythtv-setup Version: Master Head
Severity: low Keywords: DVB channel scan negative
Cc: Ticket locked: no

Description

Scanning DVB channels sometimes generates negative channel numbers, which I don't think is right

Attachments (1)

07_chanid.diff (905 bytes) - added by anonymous 3 years ago.
patch to skip freqid if length is zero

Download all attachments as: .zip

Change History (2)

Changed 3 years ago by anonymous

Attachment: 07_chanid.diff added

patch to skip freqid if length is zero

comment:1 Changed 4 days ago by Klaas de Waal

Milestone: unknown31.0
Resolution: Fixed
Status: newclosed

The negative channel numbers were apparently created by the minus sign between the freqid and the serviceid; when the freqid was empty the result is a negative serviceid value.

This is the code segment in channelscan_sm.cpp in today's master:

       if ((info.m_si_standard == "mpeg") ||
            (info.m_si_standard == "scte") ||
            (info.m_si_standard == "opencable"))
        {
            if (info.m_freqid.isEmpty())
                info.m_chan_num = QString("%1-%2")
                    .arg(info.m_source_id)
                    .arg(info.m_service_id);
            else
                info.m_chan_num = QString("%1-%2")
                    .arg(info.m_freqid)
                    .arg(info.m_service_id);
        }
  

The freqid is now only used to create the chan_num when freqid is not empty. This is equivalent to the patch in file 07_chanid.diff. Problem solved, ticket closed.

Note: See TracTickets for help on using tickets.