Opened 3 years ago

Closed 3 years ago

Last modified 21 months ago

#12882 closed Patch - Bug Fix (fixed)

mythfilldatabase causes incorrect original air date in mythweb

Reported by: Peter Bennett Owned by: Peter Bennett
Priority: minor Milestone: 0.28.1
Component: MythTV - Mythfilldatabase Version: 0.28.0
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This problem exists for xmltv grabbers, not for the data direct grabber.

In mythweb, the original air date for tv series is always showing the current year instead of the actual original air date.

This is because it uses the "airdate" column if it is non-zero, otherwise it uses the "original air date".

For TV series, airdate should not be used. (see description from dbcheck.cpp: 'airdate' is a string representing the year of release for movies and may have no meaning for other types of shows.

xmltvparser.cpp has logic that inserts the current year in airdate if there is no airdate. This should not be done for TV series.

I am proposing a fix for it, which is working for me.

The code has been like this since 2009, I am wondering why nobody has noticed the problem. Perhaps most xmltv providers do not supply a real original air date. For Schedules direct, original air date is accurate almost all of the time.

For proposed fix see here -> https://github.com/bennettpeter/mythtv/commit/de66eac

Let me know of any issues with the fix.

Change History (3)

comment:1 Changed 3 years ago by Peter Bennett <pbennett@…>

Resolution: fixed
Status: newclosed

In 1b0f7fb9f42561d20241d56c2dd575afbd10be30/mythtv:

Fix mythfilldatabase incorrectly populating airdate for TV series.

Fixes #12882

comment:2 Changed 3 years ago by Peter Bennett <pbennett@…>

In 5c18d3f91b3d30ca70f8b98de6117429c4cb9c8e/mythtv:

Fix mythfilldatabase incorrectly populating airdate for TV series.

Fixes #12882

(cherry picked from commit 1b0f7fb9f42561d20241d56c2dd575afbd10be30)

comment:3 Changed 21 months ago by Peter Bennett

Owner: changed from Peter Bennett to Peter Bennett
Note: See TracTickets for help on using tickets.