Opened 3 years ago

Last modified 3 years ago

#12901 new Bug Report - General

longeraudiograph patch

Reported by: J.Pilk@… Owned by:
Priority: minor Milestone: unknown
Component: MythTV - General Version: Unspecified
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Ever since lvr's patch from #10848 was committed, the audiograph has seemed to me to be impressive and pretty but not really useful. I use the editor many times a day, almost always with a smallest step of 1-keyframe in TV or 1-second in audio, and the claimed 1-frame display width isn't a good fit. I think it actually varies, too.

I believe that the attached patch widens the scope to 32 frames - 1.28 seconds for the UK. I'm less happy about the accuracy with which the audio buffer is refreshed and tracked during editing, so I'm posting it in the hope that someone who understands this (and C++) will have a look. It applies cleanly to current master.

Attachments (3)

longeraudiograph.patch (4.8 KB) - added by J.Pilk@… 3 years ago.
audiograph.png (472.6 KB) - added by J.Pilk@… 3 years ago.
themediff_selected.txt (3.2 KB) - added by J.Pilk@… 3 years ago.
patches to MythCenter?-Wide for this Ticket

Download all attachments as: .zip

Change History (5)

Changed 3 years ago by J.Pilk@…

Attachment: longeraudiograph.patch added

Changed 3 years ago by J.Pilk@…

Attachment: audiograph.png added

Changed 3 years ago by J.Pilk@…

Attachment: themediff_selected.txt added

patches to MythCenter?-Wide for this Ticket

comment:1 Changed 3 years ago by J.Pilk@…

I initially forgot to add a patch for the MythCenter?-Wide theme. It's a diff between current master and my local modified copy in ~/.mythtv. I don't think the second part should have been included; it just shifts the results box in the Search Recordings screens.

comment:2 Changed 3 years ago by J.Pilk@…

A few new comments. I find that the patch above is moderately useful when using larger step sizes as quoted. But the display does not update well during 1-frame steps, and the scale on the time axis is not as intended, by a factor of (samples per ms), ie 48. Work-in-progress, slowly.

Note: See TracTickets for help on using tickets.