Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#12914 closed Patch - Bug Fix (fixed)

Patch: handle duplicate xmltv ratings

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: stuartm
Priority: trivial Milestone: 29.0
Component: MythTV - Mythfilldatabase Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: no

Description

While it may not be a reasonable implementation, the xmltv definition does not preclude their being duplicate (and useless) program ratings, and there have been reports of certain upstreams occasionally providing duplicates. This results in errors from mythfilldatabase for a legitimate (although questionable value) xmltv source.

Some discussion occurred here: https://sourceforge.net/p/xmltv/mailman/message/35107996/

While the particular case which was identified above has been addressed upstream (although another recently occured), this patch also addresses the MythTV reported errors by changing the INSERT to INSERT IGNORE to meet the xmltv definition. Note that (for alternative reasons) the (legacy) datadirect guide loader also uses INSERT IGNORE, so there is precedent to ignore duplicates.

This patch has been lightly tested with manually manipulated source xmltv source file and appears to work as expected.

For what little it is worth I consider this very low priority, as the root issue is (usually) poor source guide data, and the messages are not fatal (just informatory).

github ref: https://github.com/garybuhrmaster/mythtv/commit/660272784c2cdf2485f3c9345416b24720ae5f1e

github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/660272784c2cdf2485f3c9345416b24720ae5f1e.patch

Change History (3)

comment:1 Changed 3 years ago by Ian Campbell <ijc@…>

I little later than promised on list but I have tested this in my 0.28 setup and it appears to be doing the right thing.

The backport was trivial and just involved dropping one hunk which was not needed since 0.28 doesn't have 525bf8ab04c2f1c48799d297aabfa703609f7d53.

The commit I tested is https://github.com/ijc25/mythtv/commit/c6c07a67da652bf9d56f481c87284d66e78ad537 (added to the deb-multimedia 0.28+fixes20161127-dmo1 packages, so not built from git).

comment:2 Changed 3 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: fixed
Status: newclosed

In d58a00e3e31c61d93421d0c1a6e40e316850e70d/mythtv:

mythfilldatabase: Handle duplicate programratings. Fixes #12914

Signed-off-by: Paul Harrison <pharrison@…>

comment:3 Changed 3 years ago by paulh

Milestone: unknown29.0
Note: See TracTickets for help on using tickets.