Opened 3 years ago

Closed 3 years ago

#12922 closed Patch - Bug Fix (fixed)

Patch - ExternalRecorder - Eliminate "No data from external app" message when data returned

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: JYA
Priority: minor Milestone: unknown
Component: MythTV - Recording Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

An external recorder app, even when it is providing data, can end up logging messages (in my specific case, every few minutes) of the form:

ExternSH recorders/ExternalStreamHandler.cpp:594 (run) - ExternSH(.....): No data from external app

It appears that if an external recorder apps returned data is fully consumed in the stream handler inner loop and that no more data is available in a 100ms interval (which may happen with external recorder apps that either buffer data, or receive a transport stream slowly) the stream handler will increase the counter indicating no data, even when the external recorder app has actually returned data. After 1000 such repeated events, the message is logged.

This patch resets the counter whenever data is returned from the external recorder app.

I am not entirely sure this is the correct fix, but it addresses the specific case I have observed.

Lightly tested with a prototype external recorder app.

github ref: https://github.com/garybuhrmaster/mythtv/commit/c5246059d3948045e2a224cd684c3e3beac14bb3

github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/c5246059d3948045e2a224cd684c3e3beac14bb3.patch

Change History (1)

comment:1 Changed 3 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: fixed
Status: newclosed

In f55415ed1ada1223142b3206c8da65a556121d4c/mythtv:

[PATCH] Do not report "No data from external app" when data was returned.

Signed-off-by: John Poet <jpoet@…>

Fixes #12922

Note: See TracTickets for help on using tickets.