Opened 2 years ago

Closed 2 years ago

#12939 closed Patch - Feature (fixed)

updates needed for libcec4

Reported by: ike.devolder@… Owned by: Stuart Auchterlonie
Priority: minor Milestone: 0.28.1
Component: MythTV - General Version: 0.28.0
Severity: medium Keywords: libcec
Cc: Ticket locked: no

Description

There are some big changes in libcec4 which require some updates in the mythtv code.

There is a patch to make mythtv build with libcec4 which could probably be improved further.

Change History (6)

comment:1 Changed 2 years ago by hobbes1069@…

Fedora has hit this with rawhide (F26) here's the error:

g++ -c -pipe -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DPIC -O2 -g -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables -fomit-frame-pointer -fno-devirtualize -fPIC -DQT_DISABLE_DEPRECATED_BEFORE=0x050000 -msse -pthread -Wpointer-arith -DSTDC_CONSTANT_MACROS -DSTDC_LIMIT_MACROS -fvisibility-inlines-hidden -Wmissing-declarations -Wno-switch -Woverloaded-virtual -funit-at-a-time -fvisibility=hidden -std=gnu++11 -D_REENTRANT -fPIC -DMMX -Di386 -Dusing_libcec -D_GNU_SOURCE -DUPNP_API -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_XML_LIB -DQT_SQL_LIB -DQT_SCRIPT_LIB -DQT_CORE_LIB -I. -isystem /usr/include/libxml2 -isystem /usr/include/X11 -I../libmythbase -I../libmythservicecontracts -I.. -Iserializers -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtXml -isystem /usr/include/qt5/QtSql -isystem /usr/include/qt5/QtScript -isystem /usr/include/qt5/QtCore -I. -I/usr/lib/qt5/mkspecs/linux-g++ -o servicehost.o servicehost.cpp cecadapter.cpp: In member function 'bool CECAdapterPriv::Open()': cecadapter.cpp:110:19: error: 'CEC::ICECCallbacks {aka struct CEC::ICECCallbacks}' has no member named 'CBCecLogMessage'; did you mean 'logMessage'?

callbacks.CBCecLogMessage = &CECLogMessageCallback;

cecadapter.cpp:111:19: error: 'CEC::ICECCallbacks {aka struct CEC::ICECCallbacks}' has no member named 'CBCecKeyPress'; did you mean 'keyPress'?

callbacks.CBCecKeyPress = &CECKeyPressCallback;

cecadapter.cpp:112:19: error: 'CEC::ICECCallbacks {aka struct CEC::ICECCallbacks}' has no member named 'CBCecCommand'

callbacks.CBCecCommand = &CECCommandCallback;

~

cecadapter.cpp:114:19: error: 'CEC::ICECCallbacks {aka struct CEC::ICECCallbacks}' has no member named 'CBCecAlert'

callbacks.CBCecAlert = &CECAlertCallback;

~

cecadapter.cpp:115:19: error: 'CEC::ICECCallbacks {aka struct CEC::ICECCallbacks}' has no member named 'CBCecSourceActivated'; did you mean 'sourceActivated'?

callbacks.CBCecSourceActivated = &CECSourceActivatedCallback;

~

cecadapter.cpp:134:40: error: 'class CEC::ICECAdapter' has no member named 'FindAdapters?'; did you mean 'PingAdapter?'?

uint8_t num_devices = adapter->FindAdapters?(devices, MAX_CEC_DEVICES, NULL);

~

cecadapter.cpp: In member function 'void CECAdapter::Action(const QString&)': cecadapter.cpp:777:10: warning: this 'if' clause does not guard... [-Wmisleading-indentation]

else if (ACTION_TVPOWEROFF == action)

~

cecadapter.cpp:779:9: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'

gActionsReady->wakeAll();

Full build log here: http://koji.rpmfusion.org/kojifiles/work/tasks/2431/52431/build.log

comment:3 Changed 2 years ago by hobbes1069@…

It's still finishing building the package but it has made it past the libcec part so looks to be good so far.

comment:4 Changed 2 years ago by Stuart Auchterlonie

Owner: set to Stuart Auchterlonie
Status: newaccepted

comment:5 Changed 2 years ago by Stuart Auchterlonie

comment:6 Changed 2 years ago by BlackEagle <ike.devolder@…>

Resolution: fixed
Status: acceptedclosed

In 0890206d9d303db7f10829b7d9bf574e091e70fc/mythtv:

Fixes #12939 - add compatibility for libcec4

added updates to the libcec4 interface, so mythtv can be compiled
against it. Some parts might need some cleaning.

Signed-off-by: BlackEagle? <ike.devolder@…>
(cherry picked from commit f6144655200bf2927da69186c2f22040446e7bb2)
Signed-off-by: Stuart Auchterlonie <stuarta@…>
(cherry picked from commit 65f16a504687f3ee7a42abc292f1d3e05aee71d7)

Note: See TracTickets for help on using tickets.