Opened 3 years ago

Closed 2 years ago

Last modified 20 months ago

#12950 closed Patch - Bug Fix (fixed)

python: Bump MythMusic schema from 1018 to 1024

Reported by: Ian Campbell <ijc@…> Owned by: Peter Bennett
Priority: minor Milestone: 29.1
Component: Bindings - Python Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Looking at mythplugins/mythmusic/mythmusic/dbcheck.cpp across fixes/* it seems the shipped versions were (nb: I didn't go looking for updates within those branches, this is from the tip of each):

Branch Music Db Schema
0.28, master 1024
0.26, 0.27 1020
0.25 1019
0.22, 0.23, 0.24 1017
0.21 1013

While the Python bindings have said 1018 since 0.25, updated from 1017 in 695511514a67. Looking at dbcheck.cpp the updates are:

  • 1018->1019: updates to music_albumart, not covered by bindings.
  • 1019->1020: recreates music_radios, not covered by bindings.
  • 1020->1021: adds music_songs.hostname, trivial update to MythMusic.searchMusic() binding.
  • 1021->1022: adds music_albumart.hostname, not covered by bindings.
  • 1022->1023: adds indexes to music_albumart and music_albums.
  • 1023->1024: big changes to music_radios and addition of music_streams, neither are covered by the bindings.

Apart from context conflicts in static.py this should be easily backportable to fixes/0.28 too.

github ref: https://github.com/ijc25/mythtv/commit/3b761a7b92325e7e5bbc56dfc30972118749e313 github git am ref: https://github.com/ijc25/mythtv/commit/3b761a7b92325e7e5bbc56dfc30972118749e313.patch

Attachments (3)

master.patch (2.3 KB) - added by ijc@… 2 years ago.
patch for master 121b636884b4258efebcdbe648652cb17f3e7c11
fixes29.patch (2.3 KB) - added by ijc@… 2 years ago.
patch for fixes/29 d35436d9405eb31e9e2aeef3c2fad20c6e613da6
0001-python-Bump-MythMusic-schema-from-1018-to-1024.patch (2.3 KB) - added by ijc@… 2 years ago.
2017-09-24 Rebased onto master @ 01a3b5f11b0064c3af2bceda1cf55fa0add5072a

Download all attachments as: .zip

Change History (14)

comment:1 Changed 3 years ago by Stuart Auchterlonie

Milestone: unknown0.28.1

comment:2 Changed 3 years ago by Stuart Auchterlonie

Milestone: 0.28.10.28.2

Moving remaining open 0.28.1 tickets to 0.28.2

comment:3 Changed 2 years ago by ijc@…

Looks like this has fallen through the cracks and remains an issue in master and fixes/29. Could the milestones be updated to reflect that please.

The music db schema has not changed since 0.28 so the logic still applies to the current branches. I've done the trivial forward port to master and will attach that and a fixes/29 version (which is identical).

Changed 2 years ago by ijc@…

Attachment: master.patch added

Changed 2 years ago by ijc@…

Attachment: fixes29.patch added

comment:4 Changed 2 years ago by Stuart Auchterlonie

Milestone: 0.28.229.1

comment:5 Changed 2 years ago by Peter Bennett

Owner: changed from Raymond Wagner to Peter Bennett
Status: newassigned

comment:6 Changed 2 years ago by Peter Bennett

Status: assignedinfoneeded

Things seem to have changed since you made this patch. Here is the result from git apply in master. Please fix the patch and attach an updated patch file for master. You don't need to attach one for fixes/29 as well, I can cherry-pick from master to fixes/29.

error: patch failed: mythtv/bindings/python/MythTV/static.py:7
error: mythtv/bindings/python/MythTV/static.py: patch does not apply

Changed 2 years ago by ijc@…

2017-09-24 Rebased onto master @ 01a3b5f11b0064c3af2bceda1cf55fa0add5072a

comment:7 Changed 2 years ago by ijc@…

Rebased patch attached, I also pushed the updated version to https://github.com/MythTV/mythtv/compare/master...ijc:python-bindings-musicdb-schema.

comment:8 Changed 2 years ago by Ian Campbell <ijc@…>

Resolution: fixed
Status: infoneededclosed

In 932312d91739ea6ca258ff2e7c1c154219ef938f/mythtv:

Fixes #12950 - Update Mythmusic schema in python bindings

mythmusic schema has been updated several times. This brings the python
bindings up to date.

Signed-off-by: Peter Bennett <pbennett@…>

comment:9 Changed 2 years ago by Ian Campbell <ijc@…>

In ecb1ef71f8540efb7e9e898172274e38b7fa61f1/mythtv:

Fixes #12950 - Update Mythmusic schema in python bindings

mythmusic schema has been updated several times. This brings the python
bindings up to date.

Signed-off-by: Peter Bennett <pbennett@…>
(cherry picked from commit 932312d91739ea6ca258ff2e7c1c154219ef938f)

comment:10 Changed 2 years ago by Ian Campbell <ijc@…>

In c52de39de3ad2bd31fa691bcdfd9a4b730126508/mythtv:

Fixes #12950 - Update Mythmusic schema in python bindings

mythmusic schema has been updated several times. This brings the python
bindings up to date.

Signed-off-by: Peter Bennett <pbennett@…>
(cherry picked from commit 932312d91739ea6ca258ff2e7c1c154219ef938f)

comment:11 Changed 20 months ago by Peter Bennett

Owner: changed from Peter Bennett to Peter Bennett
Note: See TracTickets for help on using tickets.