Opened 7 years ago
Closed 7 years ago
Last modified 6 years ago
#12950 closed Patch - Bug Fix (fixed)
python: Bump MythMusic schema from 1018 to 1024
Reported by: | Owned by: | Peter Bennett | |
---|---|---|---|
Priority: | minor | Milestone: | 29.1 |
Component: | Bindings - Python | Version: | Master Head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Looking at mythplugins/mythmusic/mythmusic/dbcheck.cpp across fixes/* it seems the shipped versions were (nb: I didn't go looking for updates within those branches, this is from the tip of each):
Branch | Music Db Schema |
---|---|
0.28, master | 1024 |
0.26, 0.27 | 1020 |
0.25 | 1019 |
0.22, 0.23, 0.24 | 1017 |
0.21 | 1013 |
While the Python bindings have said 1018 since 0.25, updated from 1017 in 695511514a67. Looking at dbcheck.cpp the updates are:
- 1018->1019: updates to music_albumart, not covered by bindings.
- 1019->1020: recreates music_radios, not covered by bindings.
- 1020->1021: adds music_songs.hostname, trivial update to MythMusic.searchMusic() binding.
- 1021->1022: adds music_albumart.hostname, not covered by bindings.
- 1022->1023: adds indexes to music_albumart and music_albums.
- 1023->1024: big changes to music_radios and addition of music_streams, neither are covered by the bindings.
Apart from context conflicts in static.py this should be easily backportable to fixes/0.28 too.
github ref: https://github.com/ijc25/mythtv/commit/3b761a7b92325e7e5bbc56dfc30972118749e313 github git am ref: https://github.com/ijc25/mythtv/commit/3b761a7b92325e7e5bbc56dfc30972118749e313.patch
Attachments (3)
Change History (14)
comment:1 Changed 7 years ago by
Milestone: | unknown → 0.28.1 |
---|
comment:2 Changed 7 years ago by
Milestone: | 0.28.1 → 0.28.2 |
---|
comment:3 Changed 7 years ago by
Looks like this has fallen through the cracks and remains an issue in master and fixes/29. Could the milestones be updated to reflect that please.
The music db schema has not changed since 0.28 so the logic still applies to the current branches. I've done the trivial forward port to master and will attach that and a fixes/29 version (which is identical).
Changed 7 years ago by
Attachment: | master.patch added |
---|
patch for master 121b636884b4258efebcdbe648652cb17f3e7c11
Changed 7 years ago by
Attachment: | fixes29.patch added |
---|
patch for fixes/29 d35436d9405eb31e9e2aeef3c2fad20c6e613da6
comment:4 Changed 7 years ago by
Milestone: | 0.28.2 → 29.1 |
---|
comment:5 Changed 7 years ago by
Owner: | changed from Raymond Wagner to Peter Bennett |
---|---|
Status: | new → assigned |
comment:6 Changed 7 years ago by
Status: | assigned → infoneeded |
---|
Things seem to have changed since you made this patch. Here is the result from git apply in master. Please fix the patch and attach an updated patch file for master. You don't need to attach one for fixes/29 as well, I can cherry-pick from master to fixes/29.
error: patch failed: mythtv/bindings/python/MythTV/static.py:7 error: mythtv/bindings/python/MythTV/static.py: patch does not apply
Changed 7 years ago by
Attachment: | 0001-python-Bump-MythMusic-schema-from-1018-to-1024.patch added |
---|
2017-09-24 Rebased onto master @ 01a3b5f11b0064c3af2bceda1cf55fa0add5072a
comment:7 Changed 7 years ago by
Rebased patch attached, I also pushed the updated version to https://github.com/MythTV/mythtv/compare/master...ijc:python-bindings-musicdb-schema.
comment:8 Changed 7 years ago by
Resolution: | → fixed |
---|---|
Status: | infoneeded → closed |
comment:11 Changed 6 years ago by
Owner: | changed from Peter Bennett to Peter Bennett |
---|
Moving remaining open 0.28.1 tickets to 0.28.2