Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#12963 closed Bug Report - General (fixed)

Insufficient clipinfo range check for BluRay throws "DVD Failure" message

Reported by: justin.nonwork@… Owned by: JYA
Priority: minor Milestone: 0.28.1
Component: MythTV - Blu-ray Playback Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Some new BluRays? (e.g., X-Men: Apocalypse) don't have any CLIPINF files in the range [00000,00100].clpi. This means that when BDInfo attempts to create a serial number for the BluRay? (see line 254 of https://code.mythtv.org/doxygen/bdringbuffer_8cpp_source.html ) it will fail. As a result, when main.cpp checks bd.IsValid?() (line 1207 of https://code.mythtv.org/doxygen/mythtv_2programs_2mythfrontend_2main_8cpp_source.html ) it will return false, and the user will see a "DVD Failure" message.

I confirmed this was the case by making a symlink to 00121.clpi (the first .clpi file in X-M:A's BDMV/CLIPINF directory) named 00001.clpi, and then playback worked.

Change History (6)

comment:1 Changed 3 years ago by Richard Hulme <peper03@…>

In 9974b0089f3837ff410abc5c78cba89dc7315d89/mythtv:

Try to find a .clpi file in the range 00000-00200 to generate a Bluray bookmark.

Refs #12963

comment:2 Changed 3 years ago by Richard Hulme <peper03@…>

Resolution: fixed
Status: newclosed

In 400207b50e24ef00de00654d5c7e4fdf0961cc2e/mythtv:

Don't allow an inability to create a serial number to prevent playback of a Bluray disc.

Fixes #12963

comment:3 Changed 3 years ago by Richard Hulme <peper03@…>

In d1ca41ba876997c9297600a057adb02505b6abec/mythtv:

Try to find a .clpi file in the range 00000-00200 to generate a Bluray bookmark.

Refs #12963
(cherry picked from commit 9974b0089f3837ff410abc5c78cba89dc7315d89)

comment:4 Changed 3 years ago by Richard Hulme <peper03@…>

In abf670c3cf20cc74088b9fc6e88c7f42859fae0a/mythtv:

Don't allow an inability to create a serial number to prevent playback of a Bluray disc.

Fixes #12963
(cherry picked from commit 400207b50e24ef00de00654d5c7e4fdf0961cc2e)

comment:5 Changed 3 years ago by peper03

It would be more efficient to get a list of all .clpi files and then just pick the first rather than blindly iterating through a range (that may have to get bigger and bigger) but libbluray doesn't support that and doing it by allowing it to populate all its internal structures first can take quite a long time (particularly with StorageGroups?).

The other way is to bypass libbluray but that means handling images and directories separately and potentially hitting encryption problems (although I don't think the clip info files are usually encrypted). I'll add it to my to-do list.

comment:6 Changed 3 years ago by peper03

Milestone: unknown0.28.1
Note: See TracTickets for help on using tickets.