Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#12966 closed Bug Report - General (fixed)

mythzmserver standalone build broken

Reported by: Argus <pthorn.argus@…> Owned by: paulh
Priority: minor Milestone: 0.28.1
Component: Plugin - MythZoneminder Version: 0.28.0
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In 0.28-fixes, mythplugins/mythzoneminder/mythzmserver/zmserver.cpp has a dependency on mythtv/mythconfig.h which breaks "make -f Makefile.standalone".

A normal "make" seems to still compile successfully.

Using a pre-configured directory as suggested by the wiki to create config.h (​https://www.mythtv.org/wiki/MythZoneMinder) does not fix the standalone compile and seems out of date for version 0.28.

Simply removing the mythtv/mythconfig.h dependency in zmserver.cpp seems to still compile fine and produces a workable binary. It is unclear why mythtv/mythconfig.h is required in zmserver.cpp.

Attachments (1)

zmserver.patch​ (443 bytes) - added by Argus <pthorn+argus@…> 7 years ago.
Removed mythtv/mythconfig.h

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by Argus <pthorn+argus@…>

Attachment: zmserver.patch​ added

Removed mythtv/mythconfig.h

comment:1 Changed 7 years ago by Stuart Auchterlonie

Milestone: unknown → 0.28.1
Owner: set to paulh
Status: new → assigned

comment:2 Changed 7 years ago by Argus <pthorn.argus@…>

Resolution: → fixed
Status: assigned → closed

In 11ad81e474686172b75b9824b8b391ced35a410b/mythtv:

mythzmserver: fix building the server standalone

We no longer require mythconfig.h to be present. Fixes #12966

Signed-off-by: Paul Harrison <pharrison@…>

comment:3 Changed 7 years ago by Argus <pthorn.argus@…>

In 67d9190279a1961769d2de2808667b44d04d8868/mythtv:

mythzmserver: fix building the server standalone

We no longer require mythconfig.h to be present. Fixes #12966

Signed-off-by: Paul Harrison <pharrison@…>
(cherry picked from commit 11ad81e474686172b75b9824b8b391ced35a410b)

comment:4 Changed 7 years ago by Paul Harrison <pharrison@…>

In 41f4cc7d52fbbbebf863617133daa836c6ebd772/mythtv:

mythzmserver: attempt to fix compilation on Darwin after [11ad81e474]

Refs #12966

comment:5 Changed 7 years ago by Paul Harrison <pharrison@…>

In 15cc3137243e39058e95b44e85b468807217fae5/mythtv:

mythzmserver: attempt to fix compilation on Darwin after [67d9190279]

Refs #12966

(cherry picked from commit 41f4cc7d52fbbbebf863617133daa836c6ebd772)

Note: See TracTickets for help on using tickets.