Opened 7 years ago
Closed 7 years ago
Last modified 7 years ago
#12971 closed Patch - Bug Fix (fixed)
Searching for movies based on star ratings has errors
| Reported by: | Owned by: | gigem | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.28.2 |
| Component: | MythTV - Scheduling | Version: | 0.28.0 |
| Severity: | low | Keywords: | |
| Cc: | Ticket locked: | no |
Description
The ability to search for movies based on star ratings has a range error and a rounding error.
When searching for movies with 10 star rating it uses the value "10.0" to search in the database when all ratings are scaled in the range 0.0 to 1.0 so never returns anything.
When searching for movies with other ratings it fails to account for the rounding error when converting between the database value and the displayed value so never shows the requested movies (e.g. when searching for "9 or more stars" it only shows those with 10 stars).
Attachments (1)
Change History (7)
Changed 7 years ago by
| Attachment: | star-rating.diff added |
|---|
comment:1 Changed 7 years ago by
| Milestone: | unknown → 0.28.1 |
|---|
comment:2 Changed 7 years ago by
| Milestone: | 0.28.1 → 0.28.2 |
|---|
Moving remaining open 0.28.1 tickets to 0.28.2
comment:3 Changed 7 years ago by
Is the "-0.5" to round to the nearest star rating?
Then ten stars should be >= 0.95 to go with the rest of the options, correct?
comment:4 Changed 7 years ago by
The rounding error would be handled by something like "-0.001" (randomly taken from another suggested patch)
comment:5 Changed 7 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Patch for bug