Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#12971 closed Patch - Bug Fix (fixed)

Searching for movies based on star ratings has errors

Reported by: amb@… Owned by: gigem
Priority: minor Milestone: 0.28.2
Component: MythTV - Scheduling Version: 0.28.0
Severity: low Keywords:
Cc: Ticket locked: no

Description

The ability to search for movies based on star ratings has a range error and a rounding error.

When searching for movies with 10 star rating it uses the value "10.0" to search in the database when all ratings are scaled in the range 0.0 to 1.0 so never returns anything.

When searching for movies with other ratings it fails to account for the rounding error when converting between the database value and the displayed value so never shows the requested movies (e.g. when searching for "9 or more stars" it only shows those with 10 stars).

Attachments (1)

star-rating.diff (881 bytes) - added by amb@… 4 years ago.
Patch for bug

Download all attachments as: .zip

Change History (7)

Changed 4 years ago by amb@…

Attachment: star-rating.diff added

Patch for bug

comment:1 Changed 4 years ago by Stuart Auchterlonie

Milestone: unknown0.28.1

comment:2 Changed 4 years ago by Stuart Auchterlonie

Milestone: 0.28.10.28.2

Moving remaining open 0.28.1 tickets to 0.28.2

comment:3 Changed 3 years ago by Karl Egly

Is the "-0.5" to round to the nearest star rating?

Then ten stars should be >= 0.95 to go with the rest of the options, correct?

comment:4 Changed 3 years ago by Karl Egly

The rounding error would be handled by something like "-0.001" (randomly taken from another suggested patch)

comment:5 Changed 3 years ago by Karl Dietz <dekarl@…>

Resolution: fixed
Status: newclosed

In dd05b6d0a3d137c3e6a6735cb0a5e3fa7d3933c8/mythtv:

Fix searching for movies based on star ratings

Original patch by Andrew M. Bishop
Fixes #12971

comment:6 Changed 3 years ago by Karl Dietz <dekarl@…>

In ea8cc22f2067a5c4f780855e18af4a24062d0f69/mythtv:

Fix searching for movies based on star ratings

Original patch by Andrew M. Bishop
Fixes #12971

(cherry picked from commit dd05b6d0a3d137c3e6a6735cb0a5e3fa7d3933c8)

Note: See TracTickets for help on using tickets.