Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#12981 closed Bug Report - Crash (fixed)

$this is disallowed as a parameter in PHP 7.1

Reported by: jdgbolt@… Owned by: Stuart Auchterlonie
Priority: minor Milestone: 0.28.2
Component: Plugin - MythWeb Version: 0.28.0
Severity: medium Keywords: Mythweb, PHP 7.1
Cc: Ticket locked: no

Description

Under PHP 7.1 $this was removed from being accepted as a parameter name, and the code within includes/utils.php, function _or uses $this as one of the parameters, which causes mythweb to completely break under php 7.1. It seems to work under php 7.1 here after changing it to a different value, but there could still be other places where it is broken. The code in question is in https://github.com/MythTV/mythweb/blob/master/includes/utils.php#L220 . By changing the value mythweb does seem to work using php 7.1, but there could be other parts that are subtly affected. This seems to be the related RFC for it, slated for PHP 7.1: https://wiki.php.net/rfc/this_var

Change History (3)

comment:1 Changed 2 years ago by Stuart Auchterlonie

Milestone: unknown0.28.2
Status: newaccepted

comment:2 Changed 2 years ago by Stuart Auchterlonie <stuarta@…>

Resolution: fixed
Status: acceptedclosed

In 52ff70ecfdad06b0b66f8a5ec67cefc1b55a1861/mythweb:

Fixes #12981 [php7.1] Use of this is no longer allowed

comment:3 Changed 2 years ago by Stuart Auchterlonie <stuarta@…>

In d94cf0bb5e1ffb7feaab27aae68d8214371ae266/mythweb:

Fixes #12981 [php7.1] Use of this is no longer allowed

(cherry picked from commit 52ff70ecfdad06b0b66f8a5ec67cefc1b55a1861)

Note: See TracTickets for help on using tickets.