Opened 7 years ago
Closed 4 years ago
#12997 closed Patch - Bug Fix (Unverified)
[PATCH] Country name correction
Reported by: | Owned by: | Nicolas Riendeau | |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | MythTV - General | Version: | Master Head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Country name correction for future localization tasks (zh_TW).
https://github.com/MythTV/mythtv/pull/128
Reference (if anyone is interested): https://en.wikipedia.org/wiki/Taiwan
Change History (4)
comment:1 Changed 7 years ago by
Owner: | set to Nicolas Riendeau |
---|---|
Status: | new → assigned |
comment:2 Changed 7 years ago by
comment:3 Changed 7 years ago by
Hello, thanks for the reply, I have iso3166.cpp updated as well.
I searched again in the repo, and it looks like the locale.py was generated by running ../scripts/populate_locale.py
script in the tmdb3 directory. However it looks like it's broken now, probably there's something to do with the format change in the target ISO 3166 webpage. As you mentioned that we can use Musicbrainz' variant [1], maybe we can change the populate_locale.py to do this in the future.
Thanks
comment:4 Changed 4 years ago by
Resolution: | → Unverified |
---|---|
Status: | assigned → closed |
Closing all old tickets in trac.
If your issue still persists, please open an issue in Github https://github.com/MythTV/mythtv/issues
and reference the existing trac ticket.
Thank you for looking into this.
I think it is ok to deviate from ISO 3166 and follow Musicbrainz' variant of the ISO 3166 country list. (They generally set good precedent, like adding plain north/south to the korean entries, so layman know which one is which.) https://en.wikipedia.org/wiki/ISO_3166-1#Naming_and_disputes has a note on the country name in the standard.
locales.py mentions that the list is automatically generated (But how? And from what source?). Please keep our other locale list in sync until we find out how to do so automatically. See https://github.com/MythTV/mythtv/blob/master/mythtv/libs/libmythbase/iso3166.cpp#L312