Opened 23 months ago

Closed 16 months ago

Last modified 15 months ago

#13041 closed Patch - Bug Fix (Fixed)

Update Mythweb jquery & prototype libraries

Reported by: steve@… Owned by: Stuart Auchterlonie
Priority: major Milestone: 0.28.2
Component: Plugin - MythWeb Version: 0.28.1
Severity: medium Keywords:
Cc: Ticket locked: no

Description

After upgrading to the latest MythTV dist, I'm getting Javascript issues due to the age of the jquery & prototype libraries.

The fix is to grab the latest versions from googleapis.com <http://googleapis.com>, and moving the recommend definitions up a bit.

Attachments (1)

header.php.diff (2.2 KB) - added by steve@… 23 months ago.
Unified diff of modules/_shared/tmpl/default/header.php

Download all attachments as: .zip

Change History (9)

Changed 23 months ago by steve@…

Attachment: header.php.diff added

Unified diff of modules/_shared/tmpl/default/header.php

comment:1 Changed 23 months ago by Stuart Auchterlonie

Milestone: unknown0.28.2
Status: newaccepted

comment:2 Changed 23 months ago by Stuart Auchterlonie

Just curious, what web browser do you see these errors on? I'm on Chrome Version 58.0.3029.96 and it's not complaining.

Regards Stuart

comment:3 Changed 23 months ago by steve@…

I'm on Firefox 32bit 53.0.2 for Windows The Javascript does not work at all, with the errors being shown in the developer options browser consoler

comment:4 Changed 22 months ago by Steve Campbell <steve@…>

Resolution: fixed
Status: acceptedclosed

In 9f14a8e65cab36de8fd53dd8f2598afb3e46f69b/mythweb:

Fixes #13041 - Update mythweb jquery and prototype libraries and use CDN

Signed-off-by: Stuart Auchterlonie <stuarta@…>

comment:5 Changed 22 months ago by Steve Campbell <steve@…>

In fdfca9075fda339dc30b65a1b62ed181ee6933dc/mythweb:

Fixes #13041 - Update mythweb jquery and prototype libraries and use CDN

Signed-off-by: Stuart Auchterlonie <stuarta@…>
(cherry picked from commit 9f14a8e65cab36de8fd53dd8f2598afb3e46f69b)

comment:6 Changed 16 months ago by mystica@…

Resolution: fixed
Status: closednew

This should not load the assets from a CDN because MythWeb is a local application. It should load local files only. Cross-origin blocking plugins as well as those without (reliable) network connectivity to the greater Internet are being affected.

comment:7 Changed 16 months ago by Stuart Auchterlonie

Resolution: Fixed
Status: newclosed

Mythweb's primary use case is for when you are not on the local network, so using a CDN is perfectly valid.

I've reviewed mythweb's usage of these libraries when loaded from the CDN, and as (my) mythweb is properly secured via ssl, and so are the resources from the CDN, there isn't a CORS issue here.

If you believe otherwise, please start a discussion on the mythtv-dev list.

Alternatively, feel free to download the relevant JS libraries to your local setup and change the references.

Regards Stuart

comment:8 Changed 15 months ago by Stuart Auchterlonie

Added an option to use local libraries in #13191

Note: See TracTickets for help on using tickets.