Opened 7 years ago
Closed 6 years ago
Last modified 6 years ago
#13041 closed Patch - Bug Fix (Fixed)
Update Mythweb jquery & prototype libraries
Reported by: | Owned by: | Stuart Auchterlonie | |
---|---|---|---|
Priority: | major | Milestone: | 0.28.2 |
Component: | Plugin - MythWeb | Version: | 0.28.1 |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
After upgrading to the latest MythTV dist, I'm getting Javascript issues due to the age of the jquery & prototype libraries.
The fix is to grab the latest versions from googleapis.com <http://googleapis.com>, and moving the recommend definitions up a bit.
Attachments (1)
Change History (9)
Changed 7 years ago by
Attachment: | header.php.diff added |
---|
comment:1 Changed 7 years ago by
Milestone: | unknown → 0.28.2 |
---|---|
Status: | new → accepted |
comment:2 Changed 7 years ago by
Just curious, what web browser do you see these errors on? I'm on Chrome Version 58.0.3029.96 and it's not complaining.
Regards Stuart
comment:3 Changed 7 years ago by
I'm on Firefox 32bit 53.0.2 for Windows The Javascript does not work at all, with the errors being shown in the developer options browser consoler
comment:4 Changed 7 years ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
comment:6 Changed 6 years ago by
Resolution: | fixed |
---|---|
Status: | closed → new |
This should not load the assets from a CDN because MythWeb is a local application. It should load local files only. Cross-origin blocking plugins as well as those without (reliable) network connectivity to the greater Internet are being affected.
comment:7 Changed 6 years ago by
Resolution: | → Fixed |
---|---|
Status: | new → closed |
Mythweb's primary use case is for when you are not on the local network, so using a CDN is perfectly valid.
I've reviewed mythweb's usage of these libraries when loaded from the CDN, and as (my) mythweb is properly secured via ssl, and so are the resources from the CDN, there isn't a CORS issue here.
If you believe otherwise, please start a discussion on the mythtv-dev list.
Alternatively, feel free to download the relevant JS libraries to your local setup and change the references.
Regards Stuart
Unified diff of modules/_shared/tmpl/default/header.php