Opened 2 years ago

Closed 2 years ago

Last modified 19 months ago

#13046 closed Bug Report - General (Fixed)

Bugs in mythui settings

Reported by: Peter Bennett Owned by: Peter Bennett
Priority: minor Milestone: 29.0
Component: MythTV - User Interface Library Version:
Severity: medium Keywords:
Cc: John, Pilkington, <J.Pilk@…> Ticket locked: no

Description (last modified by Peter Bennett)

New MythUI settings has a few bugs. Those marked ### are serious in that they prevent essential functionality (show stoppers). I hope to fix at least all the show stoppers for version 29. If anybody sees other bugs please log them here. (F) indicates items for which I have a fix ready for commit.

Setup

  • Master backend Host name can be updated. Should be by check box only. (Fixed 420a1ea)
  • ### Cannot delete capture card, after confrming delete it is still there. (Fixed 420a1ea) Also does not have menu, only D option. (Fixed 420a1ea)
  • After adding capture card name the list is not refreshed.
  • Capture cards prompt for save even if not changed.
  • Cannot create recording profile group. It allows you to key a name but never saves it. (Old system is the same). Change to disallow adding or deleting of recording profile groups. (Fixed 420a1ea)
  • ### Cannot delete recording profile. It does not respond to D, or to M for menu (Fixed 420a1ea)
  • After deleting recording profile the list is not refreshed. (Fixed 420a1ea)
  • After adding new video source name, the list is not refreshed.
  • Video source delete works from menu. D does nothing. (Fixed 420a1ea)
  • ### Create new storage group does not prompt for the group name and creates it with a garbage name. (Fixed 420a1ea)
  • Storage Directory Delete works from D, no menu.

Frontend

  • Initial frontend with no backend running and no config.xml invokes old DB setup page. (Fixed 7d2be78)
  • New startup screen invokes old DB setup page. (Fixed 7d2be78)
  • playback group list not refreshed after update (Already Fixed)
  • playback group changing name creates a new entry. (Already Fixed)
  • ### Cannot delete playback group. It does not respond to D, no menu (Fixed 420a1ea)
  • Channel group: when adding a new one does not show in the list. (Fixed 420a1ea)
  • Channel group does not save channels unlss you first add channel group, exit and go back in. (Fixed 420a1ea)
  • Channel group deletion is weird. (Fixed 420a1ea)
  • New playback group not saved unless you change something in it (Fixed 420a1ea)
  • If you invoke a Jump Point while in setup with some value changed but not yet saved, you are asked whether you want to exit MythTV.

General

  • Some pages prompt to save before exit even if there is no change. Others do not prompt and save anyway. Consistency needed. (Fixed 6869ba6), except for cases specifically noted above.
  • Delete is inconsistent. Sometimes it uses Menu Delete and sometimes it uses Delete button. (Fixed 420a1ea), except for cases specifically noted above.

Suggestions

  • When adding a new entry, eg storage group, it should preferably go in and edit that entry immediately instead of just leaving you in the list.
  • Escape handling is not intuitive, I think it should go back 1 level not exit completely.
  • Maybe there should be a Finish button that will finish and save so as to avoid always prompting for "do you want to save" on exit.

Attachments (1)

20170702_channelscan.patch (12.3 KB) - added by Peter Bennett 2 years ago.
Channel scan improvement patch.

Download all attachments as: .zip

Change History (40)

comment:1 Changed 2 years ago by Peter Bennett

Status: newaccepted

comment:2 Changed 2 years ago by Peter Bennett

Description: modified (diff)

comment:3 Changed 2 years ago by Peter Bennett <pbennett@…>

In 420a1ea81b512c6c37e71b7d0a168b832c1a9fc9/mythtv:

Fixes for MythUI settings

  • New Edit / Delete menu that supports all settings.
  • Remove obsolete unused channelgroupsettings.cpp and channelgroupsettings.h
  • Remove non-working unneeded Add / Delete from Recording Profile Groups.
  • Remove now superfluous class VideoSourceDialog?
  • Fixed many MythUI Setup bugs.

Refs #13046

comment:4 Changed 2 years ago by Peter Bennett

Description: modified (diff)

comment:5 Changed 2 years ago by Peter Bennett <pbennett@…>

In 6869ba6beca5c8cadf01249453260a272f6e9020/mythtv:

Fix incorrect save prompt in General Setup

Refs #13046

comment:6 Changed 2 years ago by Peter Bennett

Description: modified (diff)

comment:7 Changed 2 years ago by Peter Bennett <pbennett@…>

In fd8f137e7d1fc2c0b7e761c449e24ccd0a8da1ac/mythtv:

Merge branch 'settings' into mythtv-master

MythUI based settings pages to replace QT widget based implementation.

Refs #13046

comment:8 Changed 2 years ago by Peter Bennett <pbennett@…>

In 5cd39f1a8fc57f7b37c28fb8f719394963727da7/mythtv:

More Fixes for incorrect save prompt in General Setup

Refs #13046

comment:9 Changed 2 years ago by Stuart Auchterlonie <stuarta@…>

comment:10 Changed 2 years ago by Peter Bennett <pbennett@…>

In 7d2be781fee67bb2da2bd7c1c16bcf670e2e4e40/mythtv:

Fixes for MythUI settings

Refs #13046

comment:11 Changed 2 years ago by Peter Bennett

Description: modified (diff)

comment:12 Changed 2 years ago by Peter Bennett

Description: modified (diff)

comment:13 Changed 2 years ago by Stuart Auchterlonie

The way the scan setup pages work is counter intuitive, as you have to go "back" to "accept" the configuration you have setup in order to perform a scan.

You should go forward to configure and start a scan. ie. setup1 -> next -> setup2 -> next -> overview -> start

I also don't know that we need scan configuration and start scanning to be separate items that you have to come "back" to.

comment:14 Changed 2 years ago by Peter Bennett

Stuart

The attached patch eliminates the extra page with just "scan configuration" and "scan", and adds the Scan to the scan configuration so you just go down on the page to get to scan. Let me know if this is better. I could only do minimal testing since I do not get any DVB reception here.

Peter

Changed 2 years ago by Peter Bennett

Attachment: 20170702_channelscan.patch added

Channel scan improvement patch.

comment:15 Changed 2 years ago by Stuart Auchterlonie

Peter,

This patch is a distinct improvement. Lets get it committed.

There's still a few bits i'd like to work on with this.

  • The status bars for scan progress / snr / signal strength

are too wide, the results of the scan don't have enough room to be printed other than "Transpo...", where it used to say something like "transport blah complete, found x services"

I'm tempted to shrink them to a circle (at least snr & sig strength) whose colour represents the state.

Additionally on a big scan (ie. dvb-s2) the most recent ones are off the bottom of the screen. (ie. the results list doesn't scroll up)

  • With the scan existing transports option, the checkbox for

"scan other detected services" has disappeared. Was this intentional?

Regards Stuart

comment:16 Changed 2 years ago by Peter Bennett <pbennett@…>

In f4f98f97dabd8e93d28cc5c3e2e6f42a92c3f3f9/mythtv:

Refs #13046 - Eliminate extra page in capture card setup.

Eliminate the extra page with just "scan configuration" and "scan",
and adds the Scan to the scan configuration so you just go down
on the page to get to scan.

comment:17 in reply to:  15 Changed 2 years ago by Peter Bennett

Replying to stuarta:

This patch is a distinct improvement. Lets get it committed.

Done

There's still a few bits i'd like to work on with this.

  • The status bars for scan progress / snr / signal strength

are too wide, the results of the scan don't have enough room to be printed other than "Transpo...", where it used to say something like "transport blah complete, found x services"

Yes I noticed that, did you try different themes? I have not looked at the theming of the new setup.

I'm tempted to shrink them to a circle (at least snr & sig strength) whose colour represents the state.

Additionally on a big scan (ie. dvb-s2) the most recent ones are off the bottom of the screen. (ie. the results list doesn't scroll up)

Hopefully these can be fixed with a theme change. I will take a look.

  • With the scan existing transports option, the checkbox for

"scan other detected services" has disappeared. Was this intentional?

I don't know. I will take a look and see where it went.

comment:18 Changed 2 years ago by Peter Bennett <pbennett@…>

In b543220037b794387f8241c41261dac5175b1990/mythtv:

Refs #13046 - Fix channel scan overlapping controls.

Use percentages rather than absolute pixel counts to make the page work better
with different screen resolutions and shapes. Shorten the progress bars.

comment:19 in reply to:  15 Changed 2 years ago by Peter Bennett

Replying to stuarta:

  • The status bars for scan progress / snr / signal strength

are too wide, the results of the scan don't have enough room to be printed other than "Transpo...", where it used to say something like "transport blah complete, found x services"

I Reduced the size of the progress bars and increased the size of the results button list.

I'm tempted to shrink them to a circle (at least snr & sig strength) whose colour represents the state.

I was not tempted :)

Additionally on a big scan (ie. dvb-s2) the most recent ones are off the bottom of the screen. (ie. the results list doesn't scroll up)

I reduced the height of the list so it fits. Now when the scan is complete you can scroll upward with the arrow keys.

  • With the scan existing transports option, the checkbox for

"scan other detected services" has disappeared. Was this intentional?

I don't know what that is. I ran the mythtv-setup version 0.28 and went to Input Connections, [DVB:/dev/dvb/...] , Scan Configuration , Scan for channels If I select Scan Type = "Scan of all existing transports" there are only 2 checkboxes "Ignore signal timeout" and "Search new transports". The same two options are in the new setup page

comment:20 Changed 2 years ago by Peter Bennett

John pilkington reports a segfault in transport editor.

https://lists.gt.net/mythtv/dev/609283#609283

I am unable to use the transport editor as I have no DVB channels. Perhaps somebody else could take a look.

Version 0, edited 2 years ago by Peter Bennett (next)

comment:21 Changed 2 years ago by Peter Bennett

Cc: John Pilkington <J.Pilk@…> added

comment:22 Changed 2 years ago by Peter Bennett <pbennett@…>

In 7a1ab5001cb0f9576a913f012fcda773590d6c95/mythtv:

Refs #13046 - Fix transport editor segfault and implement adding a transport

comment:23 Changed 2 years ago by Peter Bennett

Please try the transport editor again and see if it is ok now.

comment:24 in reply to:  23 Changed 2 years ago by Jonatan Lindblad

Replying to pbennett:

Please try the transport editor again and see if it is ok now.

Thanks, I missed that you could reproduce it and was just starting to look into it.

comment:25 Changed 2 years ago by J.Pilk@…

Having already done a successful scan with the previous build, I started mythtvsetup and went straight to the Channel Editor > Video source dvb > Edit Transports

Certainly the main page is OK (and I have a Snapshot of it). Deleting and adding Multiplexes (!) looks as if it works too.

Thank you.

comment:26 Changed 2 years ago by J.Pilk@…

I now have 29pre520 from the 'buntu xenial PPA running on a ~2007 HP nc6320 laptop, 4.8x kernel with HWE stack. dmesg shows some i915 issues but mostly it works.

The initialisation of my USB DVB tuners was hit-and-miss. A twin-af9015 device now seems ok but I haven't had success with a PCTV-290e.

UI comment: The boxes for setting the tuning timeouts are too small for the values I wanted - although the actual values were updated. I was using a 1024x576 window.

comment:27 in reply to:  26 Changed 2 years ago by Peter Bennett

Replying to J.Pilk@…:

The initialisation of my USB DVB tuners was hit-and-miss. A twin-af9015 device now seems ok but I haven't had success with a PCTV-290e.

I don't think this is a setup issue. Perhaps a driver or hardware problem.

UI comment: The boxes for setting the tuning timeouts are too small for the values I wanted - although the actual values were updated. I was using a 1024x576 window.

This may be an issue with your theme. Using the default theme (MythCenter) and a 1024x576 window, there is space for a tuning timeout of 65000 (the maximum) with room to spare. What theme are you using?

comment:28 Changed 2 years ago by J.Pilk@…

Agreed. I'll see what happens with another kernel, when convenient. I see the i915 issues are in a /gpu/drm/i915/ branch :-(

It had occurred to me (later) that it might be the theme: MythCenter?-wide, slightly patched. I'll investigate. Thanks.

comment:29 Changed 2 years ago by Peter Bennett <pbennett@…>

In c80482ff3c61ffecc9df5de6cff9f8712fced9ae/mythtv:

Refs #13046 - Fix missing support for allow_single_step in spin boxes.

Many setup pages use the allow_single_step parameter for spin boxes
but that option was not implemented. This changes the use of
that parameter so that it will cause single step to be used for
the spin box left/right keys and the larger default step requested
to be used for the page up/down operation.

comment:30 Changed 2 years ago by paulh

In mythtv-setup pressing Configure in Listing Grabber does nothing.

Error in the log is:- XMLParseBase: Unable to load window 'terminal' from 'standardsetting-ui.xml'

Using MythCenter?-wide theme.

comment:31 Changed 2 years ago by Peter Bennett <pbennett@…>

In bccb8c98eba7d76b7fd206e91114ccfe0b6e2f6d/mythtv:

Refs #13046 - Add missing terminal window to theme.

Terminal window was not defined in default theme, although code
supporting it and requiring it is present.

comment:32 Changed 2 years ago by Roger Siddons

IIRC in 28 settings were only created in the database when the user changed them from their default value. New, unchanged settings wouldn't exist so would use the default value specified by the code reading them, ie GetSetting(name, default)

In 29 any absent setting is created upon entry to a settings screen containing it (it's deemed to have changed because undefined != default value). Simply entering, then exiting the screen will cause the db updates. There is no UI pop-up/indication.

This could lead to subtle behavioural changes, depending solely on whether the user has navigated the setting screens. A new install/new setting will use the GetSetting() default initially. After viewing a related setting screen the default defined by the setting screen will be used instead. Usually the various defaults are identical but that's not guaranteed.

Probably not an issue but worth noting.

comment:33 Changed 2 years ago by J.Pilk@…

That may explain the difficulty that I have reported, eg in Comment 26 and the user list, in identifying my DVB-T/T2 usb tuners. I have just gone through the process again on a laptop running 'buntu 29-fixes and PCTV-290e. After 'deleting all', the tuner 'type' was shown, but no tuner identifier string. On going round again there didn't seem to be a problem. Earlier efforts on a different box with more tuners, and attempting to define the multirec value for each before going on to the next, provoked my 'Clunky' post on 'users.'

comment:34 in reply to:  32 Changed 2 years ago by Peter Bennett

Replying to rsiddons:

In 29 any absent setting is created upon entry to a settings screen containing it (it's deemed to have changed because undefined != default value). Simply entering, then exiting the screen will cause the db updates. There is no UI pop-up/indication.

When there is a change, or a deemed change, when you escape or left arrow out of the screen, you get a pop-up asking if you want to save the changes or discard them. Have you found a case where this is not done? Perhaps in that case we should add it.

comment:35 Changed 2 years ago by Jonatan Lindblad <jlindblad@…>

In 38de2d093157302c57119c183bc544e22b8a29cc/mythtv:

Settings: Make sure to call Load() after adding a capture card

Without this the device list would be empty for HDHR and potentially
other capture card types.

Refs #13046

comment:36 Changed 2 years ago by Jonatan Lindblad <jlindblad@…>

In b9dec4387e64eac67b426bd02c9ddb74ad694e09/mythtv:

Settings: Make sure to call Load() after adding a capture card

Without this the device list would be empty for HDHR and potentially
other capture card types.

Refs #13046

(cherry picked from commit 38de2d093157302c57119c183bc544e22b8a29cc)

comment:37 Changed 2 years ago by J.Pilk@…

I just updated my laptop (comment 33) to today's build of 'buntu 29-fixes (v29.0-14-geea73b7) and re-ran mythtv-setup.real. The DVB-T/T2 usb tuner was identified immediately and scans completed as intended. Thank you!

But I did at first forget to set the multirec value, which lurks offscreen in

Input connections > > Interactions between inputs > Max recordings, and defaults to 1

comment:38 Changed 2 years ago by Peter Bennett

Resolution: Fixed
Status: acceptedclosed

I am closing this ticket, which was a catch-all for bugs in the new settings. If anybody finds another bug please open a specific ticket for the bug.

comment:39 Changed 19 months ago by Peter Bennett

Owner: changed from Peter Bennett to Peter Bennett
Note: See TracTickets for help on using tickets.