compiling with gcc 7.1.0

[sautingleung@…]

Hello

I ran into a problem compiling 0.28fixes on a gentoo box with gcc version 7.1.0. The file mythtv/mythtv/libs/libmythtv/videosource.cpp at around line 830 has a line of code "uint minor_num = minor(st.st_rdev);" which failed because the minor(st.st_rdev) function is not declared or defined. I have attached a patch that allowed the compile to complete successfully.

Hope this helps

[Stuart Auchterlonie]

fixes/0.28 compiles successfully on f26 beta which uses gcc-7.1.1

can you include the output from the compiler when this failure occurs please?

[sautingleung@…]

output of gcc -v

Using built-in specs. COLLECT_GCC=/usr/x86_64-pc-linux-gnu/gcc-bin/7.1.0/gcc COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-pc-linux-gnu/7.1.0/lto-wrapper Target: x86_64-pc-linux-gnu Configured with: /var/tmp/portage/sys-devel/gcc-7.1.0-r1/work/gcc-7.1.0/configure --host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/usr --bindir=/usr/x86_64-pc-linux-gnu/gcc-bin/7.1.0 --includedir=/usr/lib/gcc/x86_64-pc-linux-gnu/7.1.0/include --datadir=/usr/share/gcc-data/x86_64-pc-linux-gnu/7.1.0 --mandir=/usr/share/gcc-data/x86_64-pc-linux-gnu/7.1.0/man --infodir=/usr/share/gcc-data/x86_64-pc-linux-gnu/7.1.0/info --with-gxx-include-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/7.1.0/include/g++-v7 --with-python-dir=/share/gcc-data/x86_64-pc-linux-gnu/7.1.0/python --enable-languages=c,c++,fortran --enable-obsolete --enable-secureplt --disable-werror --with-system-zlib --enable-nls --without-included-gettext --enable-checking=release --with-bugurl=​https://bugs.gentoo.org/ --with-pkgversion='Gentoo 7.1.0-r1 p1.1' --disable-esp --enable-libstdcxx-time --enable-shared --enable-threads=posix --enable-cxa_atexit --enable-clocale=gnu --enable-multilib --with-multilib-list=m32,m64 --disable-altivec --disable-fixed-point --enable-targets=all --disable-libgcj --enable-libgomp --disable-libmudflap --disable-libssp --disable-libcilkrts --disable-libmpx --enable-vtable-verify --enable-libvtv --enable-lto --without-isl --enable-libsanitizer --disable-default-pie --enable-default-ssp Thread model: posix gcc version 7.1.0 (Gentoo 7.1.0-r1 p1.1)

[Stuart Auchterlonie <stuarta@…>]

In eca27c542b70deb58e50ad4581b2d6f6b2e1d3c2/mythtv:

Refs #13047 - major() and minor() are defined in <sys/sysmacros.h>

On BSD platforms they remain defined in <sys/types.h>

[Stuart Auchterlonie <stuarta@…>]

In 0a8e8423e8cc4d7ced1db96ba58caeb85c5af6e0/mythtv:

Refs #13047 - Windows also has major() and minor() in <sys/types.h>

[sautingleung@…]

Hi Stuart

I have just successfully compiled 0.28fixes on my gentoo box with the above commit reca27c542b.

Thanks for your work on this

Helen

[Stuart Auchterlonie <stuarta@…>]

In 37c41f1b411070471060b2f2d695e3a1ee8bebe3/mythtv:

Refs #13047 - fix check for OSX platforms

[Stuart Auchterlonie <stuarta@…>]

In b012ff0f6b284969183863d42a6a14eb77ed0a1d/mythtv:

Refs #13047 - major() and minor() are defined in <sys/sysmacros.h>

On BSD platforms they remain defined in <sys/types.h>

(cherry picked from commit eca27c542b70deb58e50ad4581b2d6f6b2e1d3c2)

[Stuart Auchterlonie <stuarta@…>]

In 219fbe688eab463cdf1f948270459f47bf9f0885/mythtv:

Refs #13047 - Windows also has major() and minor() in <sys/types.h>

(cherry picked from commit 0a8e8423e8cc4d7ced1db96ba58caeb85c5af6e0)

[Stuart Auchterlonie <stuarta@…>]

In 98550bedeeea666cc412fe3ee9ac3ffa12803ce5/mythtv:

Refs #13047 - fix check for OSX platforms

(cherry picked from commit 37c41f1b411070471060b2f2d695e3a1ee8bebe3)

[Stuart Auchterlonie]

These changes have now been pushed to fixes/0.28