Opened 3 years ago

Closed 16 months ago

#13051 closed Developer Task (Won't Fix)

Update libhdhomerun to v20161117

Reported by: joe.yasi@… Owned by: David Hampton
Priority: minor Milestone: 30.0
Component: MythTV - HDHomeRun Version: Master Head
Severity: medium Keywords:
Cc: ctreleaven@… Ticket locked: no

Description

The mythtv source has a fork of libhdhomerun in mythtv/external/libhdhomerun . Looking at git, this hasn't been updated since the 20130328 release. There have been several releases since then. The latest was packaged on 20161117 and is available here:

https://github.com/Silicondust/libhdhomerun

Change History (8)

comment:1 Changed 3 years ago by Silicondust

The current HEAD revision of libhdhomerun is about to be released as official (no changes expected) so recommend using HEAD on github.

Since 2013 the license has changed to LGPL 2.1 making it more mythtv friendly. Improvements to OSX support. Boolean handling now uses stdbool. Various bugfixes.

I am happy to work with a developer and answer any questions or help with any porting issues.

Nick - Silicondust

comment:2 Changed 2 years ago by Stuart Auchterlonie

Milestone: unknown30.0
Version: UnspecifiedMaster Head

comment:3 Changed 2 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Comment added so there is not duplicated work:

I'll try to work up a patch for this external library upgrade and submit it (usual caveats of "as time permits" apply).

comment:4 Changed 2 years ago by ctreleaven@…

cc me

comment:5 Changed 2 years ago by Stuart Auchterlonie

Cc: ctreleaven@… added

comment:6 Changed 2 years ago by Gary Buhrmaster <gary.buhrmaster@…>

This patch set is separated only so that a dev can more easily review it. It has undergone limited testing only with all patches applied.

Note that this resync removes local support for mingw windows cross compile (validated with the devs as no longer being relevant with the windows msvc support added), and removes the local legacy mac compile patch (I have verified on a remote mac that the library itself no longer needs the local ifdef (I think Apple changed some definitions some time ago), but I do not have the capability to test a full mythtv build on a mac. If the mac buildslave fails, I think I can try to provide a patch). With this resync there are no longer local patches to the library itself (should make future resyncs, should they be needed, easier).

Caveat Emptor: I have only tested compile and minimal functionality testing of setup and OTA recording on Linux.

Patch 0: Sync to upstream.

github ref: https://github.com/garybuhrmaster/mythtv/commit/8edaebcc36173774606eeb8a6bbf0ec1eecf088e
github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/8edaebcc36173774606eeb8a6bbf0ec1eecf088e.patch

Patch 1: Update cardutil to new API:

github ref: https://github.com/garybuhrmaster/mythtv/commit/4c047846145c93a35fbe3984ed6bd1bdadb7ffd3
github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/4c047846145c93a35fbe3984ed6bd1bdadb7ffd3.patch

Patch 2: Update libhdhomerun.pro for upstream changes for Windows compile (untested).

github ref: https://github.com/garybuhrmaster/mythtv/commit/e652544269dbc3467264b7fc9719a3c2182a3fe4
github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/e652544269dbc3467264b7fc9719a3c2182a3fe4.patch

Patch 3: Document upstream merge process

github ref: https://github.com/garybuhrmaster/mythtv/commit/7fe8dff1d2d06ed97284256e691c81e03dbbbcd4
github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/7fe8dff1d2d06ed97284256e691c81e03dbbbcd4.patch

comment:7 Changed 17 months ago by David Hampton

Owner: changed from Silicondust to David Hampton
Status: newassigned

comment:8 Changed 16 months ago by David Hampton

Resolution: Won't Fix
Status: assignedclosed

Commit 27fec2baba removed the embedded libhdhomerun. MythTV now uses the system supplied libhdhomerun library.

Note: See TracTickets for help on using tickets.