Opened 14 years ago

Closed 14 years ago

#1308 closed patch (fixed)

Add 'transcoded' flag to recorded table

Reported by: derek@… Owned by: cpinkham
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Background:

By default, I don't transcode my PVR-250 recordings, but recently started to in order to save space on my recordings partition. I wrote a script that I run from cron nightly to queue up recordings that are older than a week and then transcode them. My current work around is to simply use the fact that PVR recordings end in '.mpg' while the transcoded files are '.nuv'. I was going to mention my script on the users list for anyone who wanted it, but realized that it wasn't generic enough. It may or may not work for people who choose 'lossless transcoding' of MPEG2 files (not sure, I've never used it). It also wouldn't work for people who use software encoding. The attached patch creates a new field in the recorded table called 'transcoded' and is updated to '1' when the transcoder finishes transcoding a file. My cron script can then use this info when deciding what does and does not need to be transcoded.

Attachments (1)

transcoded_flag.patch (3.5 KB) - added by derek@… 14 years ago.
Add transcoded flag to recorded table

Download all attachments as: .zip

Change History (5)

Changed 14 years ago by derek@…

Attachment: transcoded_flag.patch added

Add transcoded flag to recorded table

comment:1 Changed 14 years ago by cpinkham

Owner: changed from Isaac Richards to cpinkham

comment:2 Changed 14 years ago by cpinkham

Status: newassigned

comment:3 Changed 14 years ago by derek@…

I was going to wait until after this patch was committed, but since you say you have to move some of the code around anyway, perhaps you can add it in all at once?

I think an extra value should be added to the TranscodingResults? enum:

enum TranscodingResults { 
    TRANSCODING_INCOMPLETE = 0, 
    TRANSCODING_COMPLETE = 1,
    TRANSCODING_RUNNING = 2
}; 

And then call 'SetTranscoded?(TRANSCODING_RUNNING)' where appropriate along with resetting it to TRANSCODING_INCOMPLETE on failure. I can write the patch myself in a new ticket after this ticket is committed if necessary, too.

comment:4 Changed 14 years ago by cpinkham

Resolution: fixed
Status: assignedclosed

(In [9029]) Add a 'transcoded' flag to the recorded table. The flag defaults to 0 and is set/unset by the JobQueue? for a running, successful, or unsuccessful transcode job. Support has also been added to the PlaybackBox? (aka the Watch Recordings Screen) for displaying a 'transcoded' icon to indicate which recordings have been transcoded. This is not present in any themes, but the support has been added.

As part of this, I cleaned up the status icon code a bit in playbackbox.cpp eliminating some repetitive code by creating a loop that checks all icons. I also added support for the new CC, HDTV, and Stereo icons to the popup help window since I was working on that area of the code.

This enhances and closes #1308. I applied the patch in #1308 then added the frontend support and reworked the status icon code while I was in there.

References #1139.

Note: See TracTickets for help on using tickets.