Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#13095 closed Bug Report - General (fixed)

Transport Editor does not work with DVB-S transponders

Reported by: jksjdevelop@… Owned by: Jonatan Lindblad
Priority: minor Milestone: 29.1
Component: MythTV - Mythtv-setup Version: v29.0
Severity: medium Keywords: DVB-S
Cc: Ticket locked: no

Description

This issue has been separated from https://code.mythtv.org/trac/ticket/13088#comment:11. The Transport Editor in Setup 6.Channel Editor does not support the editing or creation of DVB-S transports. DVB-T works ok. Attempting to edit or create a transport produces a blank page showing the parameters accociated with the selected item in the Title bar. No dialogues appear allowing data entry. The issue can be generally avoided as the transport editor under the Channel Scan works but there is no means of creating a new transport.

Attachments (3)

dvbs2_transport_editor.patch (678 bytes) - added by Jonatan Lindblad 2 years ago.
dvbs2_transport_editor_2.patch (1.7 KB) - added by Jonatan Lindblad 2 years ago.
dvbs2_transport_editor_3.patch (4.9 KB) - added by Jonatan Lindblad 2 years ago.

Download all attachments as: .zip

Change History (22)

comment:1 Changed 2 years ago by Peter Bennett

Component: MythTV - GeneralMythTV - Mythtv-setup
Owner: set to Peter Bennett
Status: newassigned

comment:2 Changed 2 years ago by Peter Bennett

Status: assignedinfoneeded

I cannot find what you are talking about. I can only find one transport editor.

Channel editor : "Edit Transports" button at bottom right hand side of screen. You can only edit the transports if an appropriate "Video Source" is selected first.

How do I get to "the transport editor under the Channel Scan"?. Channel scan is available in two places: a button on the Channel editor screen and a "Scan for channels" button on "5. Input Connections" -> Card name -> "Scan for channels". Neither of these seem to offer an "edit transports" option.

comment:3 Changed 2 years ago by jksjdevelop@…

Apologies for the confusing text

You can work round the problem by updating a single transport using:-

Select Video Source > Channel Scan > Scan Type > Scan of single existing transport > Transport >

The sequence that fails is.

Select Video Source > Edit Transports > Select a Transport or (New Transport).

This produces a blank page for DVB-S but works for DVB-T.

Considering the workround I sugest the issue is low priority - many thanks for the interest.

comment:4 Changed 2 years ago by Peter Bennett

I am still not with you. If I run mythtv-setup, there is a column of buttons. General, Capture cards, Recording profiles, etc. As far as I know, channel scanning is available from the "input connections" and "Channel editor" buttons.

I think maybe you are referring to the "Channel Editor" button. If I go in there I can select a video source from the list. Then I can select the "Channel Scan" button.Then I can select "Scan of existing transport". I can select a channel number for the existing transport. There is a scan button but no edit button. How do you edit from there? Pressing E does not help. I must be missing something.

comment:5 Changed 2 years ago by jksjdevelop@…

"I think maybe you are referring to the "Channel Editor" button" ---yes.

"If I go in there I can select a video source from the list. ---yes

"Then I can select the "Channel Scan" button." ---no

On that page select the "Edit Transports" button - two tabs on from "Channel Scan"

Does that button not appear for you -- interesting!

comment:6 Changed 2 years ago by Peter Bennett

Owner: changed from Peter Bennett to Jonatan Lindblad

I do not have access to DVB-S and I do not understand the transport editor as it applies here. I am assigning this to Jonatan, I hope he can help or shed more light. Perhaps it is a non-issue and should be closed.

comment:7 Changed 2 years ago by Jonatan Lindblad

Are you by any chance using DVB-S2? That case is not handled in https://github.com/MythTV/mythtv/blob/master/mythtv/libs/libmythtv/transporteditor.cpp#L727 which would explain why you are seeing a blank page. If you have the chance to test a patch that would be preferable, but if not I'll commit the change anyway.

comment:8 in reply to:  4 Changed 2 years ago by Jonatan Lindblad

Replying to pbennett:

I am still not with you. If I run mythtv-setup, there is a column of buttons. General, Capture cards, Recording profiles, etc. As far as I know, channel scanning is available from the "input connections" and "Channel editor" buttons.

I think maybe you are referring to the "Channel Editor" button. If I go in there I can select a video source from the list. Then I can select the "Channel Scan" button.Then I can select "Scan of existing transport". I can select a channel number for the existing transport. There is a scan button but no edit button. How do you edit from there? Pressing E does not help. I must be missing something.

The position of the transport edit button is controlled by the theme and is mandatory. If you can enter the channel editor it probably means that it's behind something else or outside the screen.

comment:9 in reply to:  7 Changed 2 years ago by jksjdevelop@…

Replying to natanojl:

Are you by any chance using DVB-S2? That case is not handled in https://github.com/MythTV/mythtv/blob/master/mythtv/libs/libmythtv/transporteditor.cpp#L727 which would explain why you are seeing a blank page. If you have the chance to test a patch that would be preferable, but if not I'll commit the change anyway.

Yes I am using DVB-S2 and could test a patch if you have one.

Changed 2 years ago by Jonatan Lindblad

comment:10 Changed 2 years ago by Jonatan Lindblad

Please try the attached patch. Thanks.

comment:11 Changed 2 years ago by Stuart Auchterlonie

Milestone: needs_triage29.1

comment:12 Changed 2 years ago by jksjdevelop@…

Patch works fine can edit an existing or add a new transport.

So to test further attempted to delete a DVB-S2 transponder and recreate it. Chose 8psk 11508500 rate 23000000 netid 2 tid 2092 on Astra 28.2

The transport editor offers the following params to edit

Digital TV Standard
Frequency
Symbol Rate
Inversion
FEC
Polarity

Settings these was not enough to scan the transponder. the message "Programmer Error: Failed to handle tune complete." was generated using Scan of single existing transport. The log contains

DTVMux: Invalid S2 modulation system parameter , aborting.

A full scan tuned (which works) offers the extra params

Mod Sys
Modulation
Roll-off

I note that DVB-T and DVB-T2 transponders are treated differently perhaps the same has to be done for sat.

Many thanks

Changed 2 years ago by Jonatan Lindblad

comment:13 Changed 2 years ago by Jonatan Lindblad

Hopefully the new patch will address the empty modulation system parameter.

comment:14 Changed 2 years ago by jksjdevelop@…

High - progressing. Trying to scan 8psk 11508500 rate 23000000 netid 2 tid 2092 on Astra 28.2

Got signal strength 94% no lock.

Error in log

DVBChan[7](/dev/dvb/adapter106/frontend0): Selected modulation parameter unsupported by this driver.

Does the Modulation 8PSK or QPSK not need to be set?

Tested a single transport scan of an existing DVB-S2 transport that worked fine.

comment:15 in reply to:  14 Changed 2 years ago by jksjdevelop@…

Replying to jksjdevelop@…:

High - progressing. Trying to scan 8psk 11508500 rate 23000000 netid 2 tid 2092 on Astra 28.2

Got signal strength 94% no lock.

Error in log

DVBChan[7](/dev/dvb/adapter106/frontend0): Selected modulation parameter unsupported by this driver.

Does the Modulation 8PSK or QPSK not need to be set?

Tested a single transport scan of an existing DVB-S2 transport that worked fine.

Just to clarify - the transport that failed was the one newly created using the transport editor having set Mod Sys to DVB-S2

Changed 2 years ago by Jonatan Lindblad

comment:16 Changed 2 years ago by Jonatan Lindblad

I had to read up on the standards, but now I really think it should work ;)

comment:17 Changed 2 years ago by jksjdevelop@…

Works fine thankyou.

Successfully deleted 8psk 11508500 rate 23000000 netid 2 tid 2092 on Astra 28.2

Created new transport to replace it and successfully tuned it.

Out of interest had to set Freaquency,Symbol Rate,Modulation,Modulation System & Polarity.

Great job!

comment:18 Changed 2 years ago by Jonatan Lindblad <jlindblad@…>

Resolution: fixed
Status: infoneededclosed

In 54a86c38783d1920be5908ba015f6e2e4e2959cd/mythtv:

Settings: Fix editing of DVB-S transports

Fixes #13095

comment:19 Changed 2 years ago by Jonatan Lindblad <jlindblad@…>

In 485676ce0e96597a0fab6d2588c290069e5b0ad8/mythtv:

Settings: Fix editing of DVB-S transports

Fixes #13095

(cherry picked from commit ac22686d41fda46311a7ab1c926fc1eab0d359cb)

Note: See TracTickets for help on using tickets.