Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#13109 closed Patch - Feature (Won't Fix)

Feature patch - Fix FIXME in

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: David Hampton
Priority: minor Milestone: 30.0
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no


Feature patch - Fix FIXME in

Commit 5ed7db9 modified the mythtv specific file to work around an issue with QMAKE_STRIP being empty by commenting out the strip.

Re-enable the strip when possible by adding in a test (!isEmpty) to the scope.

Lightly tested.

Proposed Patch follows:

diff --git a/mythtv/external/libhdhomerun/ b/mythtv/external/libhdhomerun/
index c0251bbf48..6a33dfb815 100644
--- a/mythtv/external/libhdhomerun/
+++ b/mythtv/external/libhdhomerun/
@@ -89,8 +89,7 @@ {
-    # FIXME QMAKE_STRIP is empty sometimes, skip for now
     SOURCES += hdhomerun_config.c

Change History (3)

comment:1 Changed 3 years ago by David Hampton

Owner: set to David Hampton
Status: newassigned

comment:2 Changed 3 years ago by David Hampton

Resolution: Won't Fix
Status: assignedclosed

Commit 27fec2baba removed the embedded libhdhomerun. MythTV now uses the system supplied libhdhomerun library.

comment:3 Changed 3 years ago by Stuart Auchterlonie

Milestone: needs_triage30.0
Note: See TracTickets for help on using tickets.