Opened 2 years ago

Closed 5 minutes ago

Last modified 5 minutes ago

#13126 closed Patch - Bug Fix (fixed)

'Listings' not showing movie rating for non-English languages

Reported by: Francois Gouget <fgouget@…> Owned by: Stuart Auchterlonie
Priority: minor Milestone: 31.0
Component: Plugin - MythWeb Version: Master Head
Severity: medium Keywords: patch
Cc: Ticket locked: no

Description

Following bug 13125 I switched my session language from English to French. This allowed me to recover the right category markup on the 'Listings' page.

However I immediately lost the star rating information for movies. For instance with my session language set to English I had:

Daredevil (2003, ★★½)

But as soon as I switched to French all I had left was:

Daredevil

Win some, lose some :-(

At least the fix for this one is easy: $program->category_type is not localized so it should be compared to 'movie' not t('movie') in modules/tv/tmpl/default/list_cell_program.php.

Attachments (1)

patch.diff​ (1.1 KB) - added by Francois Gouget <fgouget@…> 2 years ago.
Fixes #13126 - A program's category type is not localized.

Download all attachments as: .zip

Change History (6)

Changed 2 years ago by Francois Gouget <fgouget@…>

Attachment: patch.diff​ added

Fixes #13126 - A program's category type is not localized.

comment:1 Changed 2 years ago by Francois Gouget <fgouget@…>

I pushed a patch to GitHub? and created a pull request in case that's more practical: ​https://github.com/MythTV/mythweb/pull/24

comment:2 Changed 2 years ago by sphery

Component: MythTV - Web Frontend → Plugin - MythWeb
Owner: changed from stuartm to Stuart Auchterlonie

comment:3 Changed 21 months ago by Stuart Auchterlonie

Milestone: needs_triage → 29.2
Status: new → accepted

comment:4 Changed 5 minutes ago by Stuart Auchterlonie <stuarta@…>

Resolution: → fixed
Status: accepted → closed

In 215fce188/mythweb:

Merge pull request #24 from fgouget/master

Fixes #13126 - A program's category type is not localized.

comment:5 Changed 5 minutes ago by Stuart Auchterlonie

Milestone: 29.2 → 31.0
Note: See TracTickets for help on using tickets.