Opened 3 years ago
Closed 8 months ago
Last modified 8 months ago
#13126 closed Patch - Bug Fix (fixed)
'Listings' not showing movie rating for non-English languages
| Reported by: | Owned by: | Stuart Auchterlonie | |
|---|---|---|---|
| Priority: | minor | Milestone: | 31.0 |
| Component: | Plugin - MythWeb | Version: | Master Head |
| Severity: | medium | Keywords: | patch |
| Cc: | Ticket locked: | no |
Description
Following bug 13125 I switched my session language from English to French. This allowed me to recover the right category markup on the 'Listings' page.
However I immediately lost the star rating information for movies. For instance with my session language set to English I had:
Daredevil (2003, ★★½)
But as soon as I switched to French all I had left was:
Daredevil
Win some, lose some :-(
At least the fix for this one is easy: $program->category_type is not localized so it should be compared to 'movie' not t('movie') in modules/tv/tmpl/default/list_cell_program.php.
Attachments (1)
Change History (6)
Changed 3 years ago by
| Attachment: | patch.diff added |
|---|
comment:1 Changed 3 years ago by
I pushed a patch to GitHub? and created a pull request in case that's more practical: https://github.com/MythTV/mythweb/pull/24
comment:2 Changed 3 years ago by
| Component: | MythTV - Web Frontend → Plugin - MythWeb |
|---|---|
| Owner: | changed from stuartm to Stuart Auchterlonie |
comment:3 Changed 2 years ago by
| Milestone: | needs_triage → 29.2 |
|---|---|
| Status: | new → accepted |
comment:4 Changed 8 months ago by
| Resolution: | → fixed |
|---|---|
| Status: | accepted → closed |
comment:5 Changed 8 months ago by
| Milestone: | 29.2 → 31.0 |
|---|
Fixes #13126 - A program's category type is not localized.