[PATCH] Fixes for regressions in tvdb

[Ian Campbell <ijc@…>]

With the move from v1 to v2 api for ttvdb I noticed in my logs:

E MetadataImageDownload metadataimagedownload.cpp:255 (run) Tried to write http://thetvdb.com/banners/, but it appears to be an HTML redirect or corrupt file (filesize 235).

This comes from:

$ ttvdb.py -l en -a GB -C 330432
<?xml version='1.0' encoding='UTF-8'?>
<metadata>
  <item>
    <language>en</language>
    <title>Nine Minute Ninja</title>
    <network>CBBC</network>
    <description>Art Ninja spinoff. Ricky makes art in nine minutes.</description>
    <studios>
      <studio name="CBBC"/>
    </studios>
    <runtime>10</runtime>
    <inetref>330432</inetref>
    <userrating>0</userrating>
    <ratingcount>0</ratingcount>
    <year>2015</year>
    <releasedate>2015-06-24</releasedate>
    <lastupdated>Wed, 20 Sep 2017 20:43:40 GMT</lastupdated>
    <status>Continuing</status>
    <images>
      <image type="coverart" url="http://www.thetvdb.com/banners/posters/330432-1.jpg" thumb="http://www.thetvdb.com/banners/_cache/posters/330432-1.jpg"/>
      <image type="banner" url="http://thetvdb.com/banners/" thumb="http://thetvdb.com/banners/_cache/"/>
    </images>
  </item>
</metadata>

Compared with v29.0 where I see:

$ ttvdb.py -l en -a GB -C 330432
<?xml version='1.0' encoding='UTF-8'?>
<metadata>
  <item>
    <language>en</language>
    <title>Nine Minute Ninja</title>
    <network>CBBC</network>
    <description>Art Ninja spinoff. Ricky makes art in nine minutes.</description>
    <categories>
      <category type="genre" name="Children"/>
    </categories>
    <studios>
      <studio name="CBBC"/>
    </studios>
    <runtime>10</runtime>
    <inetref>330432</inetref>
    <ratingcount>0</ratingcount>
    <year>2015</year>
    <releasedate>2015-06-24</releasedate>
    <lastupdated>Wed, 20 Sep 2017 20:43:40 GMT</lastupdated>
    <status>Continuing</status>
    <images>
      <image type="coverart" url="http://www.thetvdb.com/banners/posters/330432-1.jpg" thumb="http://www.thetvdb.com/banners/_cache/posters/330432-1.jpg"/>
    </images>
  </item>
</metadata>

So as well as the bogus/strange banner the genre's are missing and their is a spurious (?) userrating of 0.

When I came to fix I also found that doctest was broken so I fixed those before fixing the issue I had seen and adding a test case for it.

Patches are available in ​https://github.com/MythTV/mythtv/compare/master...ijc:ttvdb-fixes. I'll also attach here.

[ijc@…]

6 patches in tarball

[ijc@…]

Second patch in the series was rejected due to containing too many URLs (it touches a test case which contains URLs) so rather than continuing to attach them individually I have attached a tarball with all 6 patches it it.

[Mark Spieth]

Reviewed. LGTM good removal of brittleness of the doctests.

[Peter Bennett]

Patch 1/6

[Peter Bennett]

Patch 2/6

[Peter Bennett]

Patch 3/6

[Peter Bennett]

Patch 4/6

[Peter Bennett]

Patch 5/6

[Peter Bennett]

Patch 6/6

[Peter Bennett]

6 patches combined

[Ian Campbell <ijc@…>]

In 09090e1ff99468da4f0cc44c0f6b5b98a7ae34be/mythtv:

ttvdb: Various fixes

1. ttvdb: Update "Fixer Upper" test cases with wildcards

"Lastupdated" field has changed, and seems likely to change, so make it a
wildcard match. "Thumbauthor" field has also changed.

2. Update "NOVA: Eclipse Over America" test case

This appears to have moved from episode 18 to episode 11 and had updates
to the description and other metadata.

3. Ignore banner of just "​http://thetvdb.com/banners/"
4. ignore user rating of 0
5. correct handingly of genre

They are a list of "<item>..</item>".

6. Add new test case: ttvdb.py -l en -a GB -C 330432

This had some regressions compared to v29.0 which are now fixed, so add a test case.

Fixes #13130

Signed-off-by: Peter Bennett <pbennett@…>

[Ian Campbell <ijc@…>]

In ed4356116a754b4c13e83567b5458080f80dcd59/mythtv:

ttvdb: Various fixes

1. ttvdb: Update "Fixer Upper" test cases with wildcards

"Lastupdated" field has changed, and seems likely to change, so make it a
wildcard match. "Thumbauthor" field has also changed.

2. Update "NOVA: Eclipse Over America" test case

This appears to have moved from episode 18 to episode 11 and had updates
to the description and other metadata.

3. Ignore banner of just "​http://thetvdb.com/banners/"
4. ignore user rating of 0
5. correct handingly of genre

They are a list of "<item>..</item>".

6. Add new test case: ttvdb.py -l en -a GB -C 330432

This had some regressions compared to v29.0 which are now fixed, so add a test case.

Fixes #13130

Signed-off-by: Peter Bennett <pbennett@…>
(cherry picked from commit 09090e1ff99468da4f0cc44c0f6b5b98a7ae34be)

[Ian Campbell <ijc@…>]

In 172459d73771cf44b0ec7a0914387b112d9226b4/mythtv:

ttvdb: Various fixes

1. ttvdb: Update "Fixer Upper" test cases with wildcards

"Lastupdated" field has changed, and seems likely to change, so make it a
wildcard match. "Thumbauthor" field has also changed.

2. Update "NOVA: Eclipse Over America" test case

This appears to have moved from episode 18 to episode 11 and had updates
to the description and other metadata.

3. Ignore banner of just "​http://thetvdb.com/banners/"
4. ignore user rating of 0
5. correct handingly of genre

They are a list of "<item>..</item>".

6. Add new test case: ttvdb.py -l en -a GB -C 330432

This had some regressions compared to v29.0 which are now fixed, so add a test case.

Fixes #13130

Signed-off-by: Peter Bennett <pbennett@…>
(cherry picked from commit 09090e1ff99468da4f0cc44c0f6b5b98a7ae34be)